You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/02/05 20:46:03 UTC
[GitHub] [knox] smolnar82 commented on a change in pull request #252:
KNOX-2207 - TokenStateService revocation should remove persisted token state
smolnar82 commented on a change in pull request #252: KNOX-2207 - TokenStateService revocation should remove persisted token state
URL: https://github.com/apache/knox/pull/252#discussion_r375498189
##########
File path: gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/AliasBasedTokenStateService.java
##########
@@ -125,6 +120,19 @@ protected boolean isUnknown(final String token) {
return isUnknown;
}
+ @Override
+ protected void removeToken(final String token) {
+ validateToken(token);
+
+ try {
+ aliasService.removeAliasForCluster(AliasService.NO_CLUSTER_NAME, token);
+ aliasService.removeAliasForCluster(AliasService.NO_CLUSTER_NAME,token + "--max");
+ } catch (AliasServiceException e) {
+ log.failedToUpdateTokenExpiration(e);
Review comment:
This seems a misleading log message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services