You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/04 04:24:13 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #9089: ARROW-11122: [Rust] Added FFI support for date and time.
jorgecarleitao opened a new pull request #9089:
URL: https://github.com/apache/arrow/pull/9089
Like the PR title says, it is just completing the matrix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9089: ARROW-11122: [Rust] Added FFI support for date and time.
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9089:
URL: https://github.com/apache/arrow/pull/9089
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #9089: ARROW-11122: [Rust] Added FFI support for date and time.
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #9089:
URL: https://github.com/apache/arrow/pull/9089#discussion_r553449350
##########
File path: rust/arrow-pyarrow-integration-testing/src/lib.rs
##########
@@ -153,10 +153,25 @@ fn substring(array: PyObject, start: i64, py: Python) -> PyResult<PyObject> {
to_py(array, py)
}
+/// Returns the concatenate
Review comment:
Looks like it to me -- but I think it can be improved in a follow on PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9089: ARROW-11122: [Rust] Added FFI support for date and time.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9089:
URL: https://github.com/apache/arrow/pull/9089#issuecomment-753752955
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9089?src=pr&el=h1) Report
> Merging [#9089](https://codecov.io/gh/apache/arrow/pull/9089?src=pr&el=desc) (887df6e) into [master](https://codecov.io/gh/apache/arrow/commit/86cf246d161512923253baa8fe62e00de88db73a?el=desc) (86cf246) will **increase** coverage by `0.07%`.
> The diff coverage is `88.14%`.
[](https://codecov.io/gh/apache/arrow/pull/9089?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9089 +/- ##
==========================================
+ Coverage 82.60% 82.68% +0.07%
==========================================
Files 204 204
Lines 50175 50307 +132
==========================================
+ Hits 41447 41595 +148
+ Misses 8728 8712 -16
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9089?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow-pyarrow-integration-testing/src/lib.rs](https://codecov.io/gh/apache/arrow/pull/9089/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy1weWFycm93LWludGVncmF0aW9uLXRlc3Rpbmcvc3JjL2xpYi5ycw==) | `0.00% <ø> (ø)` | |
| [rust/parquet/src/schema/types.rs](https://codecov.io/gh/apache/arrow/pull/9089/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9zY2hlbWEvdHlwZXMucnM=) | `89.52% <50.00%> (-0.42%)` | :arrow_down: |
| [rust/parquet/src/arrow/array\_reader.rs](https://codecov.io/gh/apache/arrow/pull/9089/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9hcnJheV9yZWFkZXIucnM=) | `75.44% <69.56%> (+0.09%)` | :arrow_up: |
| [rust/arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow/pull/9089/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZmZpLnJz) | `75.95% <83.87%> (+3.73%)` | :arrow_up: |
| [rust/arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow/pull/9089/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfc3RyaW5nLnJz) | `88.88% <87.50%> (-1.06%)` | :arrow_down: |
| [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9089/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.98% <100.00%> (+0.43%)` | :arrow_up: |
| [rust/arrow/src/datatypes.rs](https://codecov.io/gh/apache/arrow/pull/9089/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZGF0YXR5cGVzLnJz) | `77.66% <100.00%> (+2.63%)` | :arrow_up: |
| [rust/arrow/src/record\_batch.rs](https://codecov.io/gh/apache/arrow/pull/9089/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvcmVjb3JkX2JhdGNoLnJz) | `83.96% <100.00%> (+10.13%)` | :arrow_up: |
| [rust/parquet/src/arrow/arrow\_reader.rs](https://codecov.io/gh/apache/arrow/pull/9089/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9hcnJvd19yZWFkZXIucnM=) | `91.57% <100.00%> (+0.18%)` | :arrow_up: |
| [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9089/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `91.52% <100.00%> (+0.58%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/arrow/pull/9089/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9089?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9089?src=pr&el=footer). Last update [a745299...887df6e](https://codecov.io/gh/apache/arrow/pull/9089?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9089: ARROW-11122: [Rust] Added FFI support for date and time.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9089:
URL: https://github.com/apache/arrow/pull/9089#issuecomment-753757119
https://issues.apache.org/jira/browse/ARROW-11122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9089: ARROW-11122: [Rust] Added FFI support for date and time.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9089:
URL: https://github.com/apache/arrow/pull/9089#issuecomment-753752955
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9089?src=pr&el=h1) Report
> Merging [#9089](https://codecov.io/gh/apache/arrow/pull/9089?src=pr&el=desc) (3542976) into [master](https://codecov.io/gh/apache/arrow/commit/86cf246d161512923253baa8fe62e00de88db73a?el=desc) (86cf246) will **decrease** coverage by `0.00%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/arrow/pull/9089?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9089 +/- ##
==========================================
- Coverage 82.60% 82.60% -0.01%
==========================================
Files 204 204
Lines 50175 50203 +28
==========================================
+ Hits 41447 41468 +21
- Misses 8728 8735 +7
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9089?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow-pyarrow-integration-testing/src/lib.rs](https://codecov.io/gh/apache/arrow/pull/9089/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy1weWFycm93LWludGVncmF0aW9uLXRlc3Rpbmcvc3JjL2xpYi5ycw==) | `0.00% <ø> (ø)` | |
| [rust/arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow/pull/9089/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZmZpLnJz) | `72.90% <80.00%> (+0.67%)` | :arrow_up: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9089/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9089?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9089?src=pr&el=footer). Last update [86cf246...3542976](https://codecov.io/gh/apache/arrow/pull/9089?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on a change in pull request #9089: ARROW-11122: [Rust] Added FFI support for date and time.
Posted by GitBox <gi...@apache.org>.
nevi-me commented on a change in pull request #9089:
URL: https://github.com/apache/arrow/pull/9089#discussion_r551586245
##########
File path: rust/arrow-pyarrow-integration-testing/src/lib.rs
##########
@@ -153,10 +153,25 @@ fn substring(array: PyObject, start: i64, py: Python) -> PyResult<PyObject> {
to_py(array, py)
}
+/// Returns the concatenate
Review comment:
Is the doc comment complete?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org