You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/09 13:00:13 UTC
[GitHub] [airflow] aranjanthakur opened a new pull request #10261: 10166 : Add capability to specify gunicorn access log format for airf…
aranjanthakur opened a new pull request #10261:
URL: https://github.com/apache/airflow/pull/10261
…low webserver
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10261: 10166 : Add capability to specify gunicorn access log format for airflow
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10261:
URL: https://github.com/apache/airflow/pull/10261#issuecomment-731908273
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #10261: 10166 : Add capability to specify gunicorn access log format for airflow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10261:
URL: https://github.com/apache/airflow/pull/10261#issuecomment-731908174
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aranjanthakur commented on pull request #10261: 10166 : Add capability to specify gunicorn access log format for airflow
Posted by GitBox <gi...@apache.org>.
aranjanthakur commented on pull request #10261:
URL: https://github.com/apache/airflow/pull/10261#issuecomment-683413302
@mik-laj could you please review the changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #10261: 10166 : Add capability to specify gunicorn access log format for airflow
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10261:
URL: https://github.com/apache/airflow/pull/10261#discussion_r483312664
##########
File path: airflow/config_templates/config.yml
##########
@@ -861,6 +861,13 @@
type: string
example: ~
default: "-"
+ - name: access_logformat
+ description: |
+ Access log format for gunicorn webserver
Review comment:
A link to documentation that describes possible format argument would be helpful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aranjanthakur commented on pull request #10261: 10166 : Add capability to specify gunicorn access log format for airflow
Posted by GitBox <gi...@apache.org>.
aranjanthakur commented on pull request #10261:
URL: https://github.com/apache/airflow/pull/10261#issuecomment-721658459
Hi @mik-laj, I was having issue with the CI earlier. Some of the checks were getting cancelled intermittently. Now they are passing. Could you please approve this if the changes look good?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #10261: 10166 : Add capability to specify gunicorn access log format for airflow
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #10261:
URL: https://github.com/apache/airflow/pull/10261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10261: 10166 : Add capability to specify gunicorn access log format for airflow
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10261:
URL: https://github.com/apache/airflow/pull/10261#issuecomment-688574641
We have a problem with CI. I restarted it. If that doesn't help, please rebase and png me again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aranjanthakur commented on a change in pull request #10261: 10166 : Add capability to specify gunicorn access log format for airflow
Posted by GitBox <gi...@apache.org>.
aranjanthakur commented on a change in pull request #10261:
URL: https://github.com/apache/airflow/pull/10261#discussion_r483374690
##########
File path: airflow/config_templates/config.yml
##########
@@ -861,6 +861,13 @@
type: string
example: ~
default: "-"
+ - name: access_logformat
+ description: |
+ Access log format for gunicorn webserver
+ version_added: ~
+ type: string
+ example: ~
+ default: "%%(h)s %%(l)s %%(u)s %%(t)s \"%%(r)s\" %%(s)s %%(b)s \"%%(f)s\" \"%%(a)s\""
Review comment:
Made changes, so that we don't need to specify default config. If empty value is passed, default value for gunicorn will be used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #10261: 10166 : Add capability to specify gunicorn access log format for airflow
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10261:
URL: https://github.com/apache/airflow/pull/10261#discussion_r483312454
##########
File path: airflow/config_templates/config.yml
##########
@@ -861,6 +861,13 @@
type: string
example: ~
default: "-"
+ - name: access_logformat
+ description: |
+ Access log format for gunicorn webserver
+ version_added: ~
+ type: string
+ example: ~
+ default: "%%(h)s %%(l)s %%(u)s %%(t)s \"%%(r)s\" %%(s)s %%(b)s \"%%(f)s\" \"%%(a)s\""
Review comment:
Should we define default value? If we pass an empty value, the default value for gunicorn will not be used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aranjanthakur commented on pull request #10261: 10166 : Add capability to specify gunicorn access log format for airflow
Posted by GitBox <gi...@apache.org>.
aranjanthakur commented on pull request #10261:
URL: https://github.com/apache/airflow/pull/10261#issuecomment-688339311
@mik-laj please approve if the changes look good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10261: 10166 : Add capability to specify gunicorn access log format for airflow
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10261:
URL: https://github.com/apache/airflow/pull/10261#issuecomment-671051054
In this case, I think unit testing is good enough. To write them, you have to mock `subprocess.Popen` and `GunicornMonitor`. Here is docs about mocking in Python: https://docs.python.org/3/library/unittest.mock.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aranjanthakur commented on a change in pull request #10261: 10166 : Add capability to specify gunicorn access log format for airflow
Posted by GitBox <gi...@apache.org>.
aranjanthakur commented on a change in pull request #10261:
URL: https://github.com/apache/airflow/pull/10261#discussion_r483374775
##########
File path: airflow/config_templates/config.yml
##########
@@ -861,6 +861,13 @@
type: string
example: ~
default: "-"
+ - name: access_logformat
+ description: |
+ Access log format for gunicorn webserver
Review comment:
Added link to documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10261: 10166 : Add capability to specify gunicorn access log format for airf…
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10261:
URL: https://github.com/apache/airflow/pull/10261#issuecomment-671049219
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org