You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/22 12:44:25 UTC
[GitHub] [spark] cloud-fan commented on issue #26173: [SPARK-29503][SQL]
Copy result row from RowWriter in GenerateUnsafeProjection when the
expression is lambdaFunction in MapObject
cloud-fan commented on issue #26173: [SPARK-29503][SQL] Copy result row from RowWriter in GenerateUnsafeProjection when the expression is lambdaFunction in MapObject
URL: https://github.com/apache/spark/pull/26173#issuecomment-544943953
it's safer to make the `copy` supports mixed safe and unsafe data, but I agree with the perf concern from @viirya .
How many places do we create mixed safe and unsafe data? It looks to me that there is only one: `UnsafeProjection.toUnsafeExprs` only converts create_struct, but not create_array and create_map.
Furthermore, I don't quite understand why we need `CreateNamedStructUnsafe`. Can we simplfy remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org