You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/04/05 22:00:19 UTC
Re: Review Request 58186: Stop logging the HTTP user agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58186/
-----------------------------------------------------------
(Updated April 5, 2017, 10 p.m.)
Review request for mesos and Anand Mazumdar.
Changes
-------
Rebased.
Summary (updated)
-----------------
Stop logging the HTTP user agent.
Bugs: MESOS-7340
https://issues.apache.org/jira/browse/MESOS-7340
Repository: mesos
Description
-------
The HTTP user agent can be quite noisy in log files, but is not
particularly helpful.
Diffs (updated)
-----
src/common/http.cpp 89133e0175ffb792ae95705315844a32550470a1
Diff: https://reviews.apache.org/r/58186/diff/2/
Changes: https://reviews.apache.org/r/58186/diff/1-2/
Testing
-------
Make check (Fedora 25). Manual inspection of log output.
Thanks,
James Peach
Re: Review Request 58186: Stop logging the HTTP user agent.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58186/#review171236
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58185, 58239, 58223, 58186]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 6, 2017, 10:38 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58186/
> -----------------------------------------------------------
>
> (Updated April 6, 2017, 10:38 a.m.)
>
>
> Review request for mesos and Anand Mazumdar.
>
>
> Bugs: MESOS-7340
> https://issues.apache.org/jira/browse/MESOS-7340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The HTTP user agent can be quite noisy in log files, but is not
> particularly helpful.
>
>
> Diffs
> -----
>
> src/common/http.cpp 89133e0175ffb792ae95705315844a32550470a1
>
>
> Diff: https://reviews.apache.org/r/58186/diff/3/
>
>
> Testing
> -------
>
> Make check (Fedora 25). Manual inspection of log output.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 58186: Stop logging the HTTP user agent.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58186/
-----------------------------------------------------------
(Updated April 6, 2017, 5:38 p.m.)
Review request for mesos and Anand Mazumdar.
Changes
-------
Rebased.
Bugs: MESOS-7340
https://issues.apache.org/jira/browse/MESOS-7340
Repository: mesos
Description
-------
The HTTP user agent can be quite noisy in log files, but is not
particularly helpful.
Diffs (updated)
-----
src/common/http.cpp 89133e0175ffb792ae95705315844a32550470a1
Diff: https://reviews.apache.org/r/58186/diff/3/
Changes: https://reviews.apache.org/r/58186/diff/2-3/
Testing
-------
Make check (Fedora 25). Manual inspection of log output.
Thanks,
James Peach
Re: Review Request 58186: Stop logging the HTTP user agent.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58186/#review171187
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58185, 58223, 58186]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 5, 2017, 10 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58186/
> -----------------------------------------------------------
>
> (Updated April 5, 2017, 10 p.m.)
>
>
> Review request for mesos and Anand Mazumdar.
>
>
> Bugs: MESOS-7340
> https://issues.apache.org/jira/browse/MESOS-7340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The HTTP user agent can be quite noisy in log files, but is not
> particularly helpful.
>
>
> Diffs
> -----
>
> src/common/http.cpp 89133e0175ffb792ae95705315844a32550470a1
>
>
> Diff: https://reviews.apache.org/r/58186/diff/2/
>
>
> Testing
> -------
>
> Make check (Fedora 25). Manual inspection of log output.
>
>
> Thanks,
>
> James Peach
>
>