You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by nfalco79 <gi...@git.apache.org> on 2016/11/23 19:25:16 UTC
[GitHub] maven-wagon pull request #29: [WAGON-467] Allow customisation of some SSH op...
GitHub user nfalco79 opened a pull request:
https://github.com/apache/maven-wagon/pull/29
[WAGON-467] Allow customisation of some SSH options
This commit add StrictHostKeyChecking and PreferredAuthentications custom fields that together allow you to perform, the command scp enough to remove any user interaction (username, password and add host key to know_hosts file).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nfalco79/maven-wagon feature/WAGON-467
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-wagon/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit b5f312c5dca59b745662fd81a9e24401d1322ebc
Author: Nikolas Falco <ni...@finantix.com>
Date: 2016-11-23T19:24:41Z
[WAGON-467] Allow customisation of some SSH options
This commit add StrictHostKeyChecking and PreferredAuthentications custom fields that together allow you to perform, the command scp enough to remove any user interaction (username, password and add host key to know_hosts file).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon issue #29: [WAGON-467] Allow customisation of some SSH options
Posted by nfalco79 <gi...@git.apache.org>.
Github user nfalco79 commented on the issue:
https://github.com/apache/maven-wagon/pull/29
Follow my settings.xml
{code:xml}
<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
https://maven.apache.org/xsd/settings-1.0.0.xsd">
<servers>
<server>
<id>raspberry</id>
<username>pi</username>
<password>password</password>
<configuration>
<strictHostKeyChecking>no</strictHostKeyChecking>
<preferredAuthentications>publickey,password</preferredAuthentications>
<interactive>false</interactive>
</configuration>
</server>
</servers>
</settings>
{code}
I had play with the repository you post.
The reason because your wagon-mave-plugin does not works is because when you instantiate the wagon instance you do not consider the configuration element as the site-plugin does in [AbstractDeployMojo#configureWagon|http://svn.apache.org/viewvc/maven/plugins/tags/maven-site-plugin-3.6/src/main/java/org/apache/maven/plugins/site/deploy/AbstractDeployMojo.java?view=markup#l678] by the XmlPlexusConfiguration
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon issue #29: [WAGON-467] Allow customisation of some SSH options
Posted by dantran <gi...@git.apache.org>.
Github user dantran commented on the issue:
https://github.com/apache/maven-wagon/pull/29
@nfalco79, since i used the patch method and push this change. Git cant close this PR. Please close it yourself
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon issue #29: [WAGON-467] Allow customisation of some SSH options
Posted by dantran <gi...@git.apache.org>.
Github user dantran commented on the issue:
https://github.com/apache/maven-wagon/pull/29
your patch fixes the site plugin ssh issue. I will need to implement similar wagon handling developed at maven-site-plugin https://github.com/mojohaus/wagon-maven-plugin/issues/6
thanks for trouble shooting this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon issue #29: [WAGON-467] Allow customisation of some SSH options
Posted by nfalco79 <gi...@git.apache.org>.
Github user nfalco79 commented on the issue:
https://github.com/apache/maven-wagon/pull/29
Debugging a log the issue seems to be which implementation of WagonManger plexus inject. If I run with maven 3.3.9 it injects a [DefaultWagonManager](http://grepcode.com/file/repo1.maven.org/maven2/org.apache.maven/maven-compat/3.3.3/org/apache/maven/repository/legacy/DefaultWagonManager.java#DefaultWagonManager.getWagon%28org.apache.maven.wagon.repository.Repository%29) where the getWagon is deprecated and lacks of configureWagon call that do the trick above. If I run it with maven 2.2.1 it has a working implementation of [DefaultWagonManager](http://grepcode.com/file/repo1.maven.org/maven2/org.apache.maven/maven-artifact-manager/2.2.1/org/apache/maven/artifact/manager/DefaultWagonManager.java#DefaultWagonManager.getWagon%28org.apache.maven.wagon.repository.Repository%29) but mvn command breaks with the following message:
```
[INFO] Unable to initialise extensions
Component descriptor role: 'com.jcraft.jsch.UIKeyboardInteractive', implementation: 'org.apache.maven.wagon.providers.ssh.jsch.interactive.PrompterUIKeyboardInteractive', role hint: 'default' has a hint, but there are other implementations that don't
```
This explains the reason of extra work in the maven-site-plugin around configureWagon method to distinguish of maven 2/3
I hope these information will help you to make a workaround for your wagon-maven-plugin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon issue #29: [WAGON-467] Allow customisation of some SSH options
Posted by dantran <gi...@git.apache.org>.
Github user dantran commented on the issue:
https://github.com/apache/maven-wagon/pull/29
@nfalco79 it is a long waited fix. Thank you and thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon pull request #29: [WAGON-467] Allow customisation of some SSH op...
Posted by nfalco79 <gi...@git.apache.org>.
Github user nfalco79 closed the pull request at:
https://github.com/apache/maven-wagon/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon issue #29: [WAGON-467] Allow customisation of some SSH options
Posted by dantran <gi...@git.apache.org>.
Github user dantran commented on the issue:
https://github.com/apache/maven-wagon/pull/29
@nfalco79 could you give https://github.com/mojohaus/wagon-maven-plugin/tree/master/src/it/ssh-it a try? update the pom to use your env. I am not able to get mine working. It always prompts me for host key confirmation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon issue #29: [WAGON-467] Allow customisation of some SSH options
Posted by nfalco79 <gi...@git.apache.org>.
Github user nfalco79 commented on the issue:
https://github.com/apache/maven-wagon/pull/29
closed by this ffa7fc8830e916e9d3d91a222b641cd5363ffafe
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon issue #29: [WAGON-467] Allow customisation of some SSH options
Posted by dantran <gi...@git.apache.org>.
Github user dantran commented on the issue:
https://github.com/apache/maven-wagon/pull/29
confirm it works with maven-site-plugin but not with wagon-maven-plugin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org