You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2023/07/27 14:05:14 UTC
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20274
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
UnnestExpr can be used in a sort tuple which won't have a resolved path.
In such case, there are no parent tuple id so we should not check it in
UnnestExpr.isBoundByTupleIds(). This fixes the NullPointerException.
Tests
- Added e2e test for sorting columns come from unnest().
- Move test_zipping_unnest_from_view to a dedicated class that only has
the parquet file_format dimension to make sure it also runs in "core"
exploration strategy. Before this it only runs in "exhaustive"
strategy.
Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
---
M fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java
M testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-from-view.test
M tests/query_test/test_nested_types.py
3 files changed, 122 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/20274/1
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Gabor Kaszab, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20274
to look at the new patch set (#2).
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
UnnestExpr can be used in a sort tuple which won't have a resolved path.
In such case, there is no parent tuple id so we should not check it in
UnnestExpr.isBoundByTupleIds(). This fixes the NullPointerException.
Tests
- Added fe and e2e tests for sorting columns come from unnest().
- Move test_zipping_unnest_from_view to a dedicated class that only has
the parquet file_format dimension to make sure it also runs in "core"
exploration strategy. Before this it only runs in "exhaustive"
strategy.
Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
---
M fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java
M testdata/workloads/functional-planner/queries/PlannerTest/zipping-unnest.test
M testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-from-view.test
M tests/query_test/test_nested_types.py
4 files changed, 257 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/20274/2
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20274 )
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Jul 2023 06:42:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20274 )
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Thanks, looks good, just a nit.
http://gerrit.cloudera.org:8080/#/c/20274/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20274/1//COMMIT_MSG@10
PS1, Line 10: are
Nit: is.
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 27 Jul 2023 16:35:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20274 )
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 31 Jul 2023 00:48:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/20274 )
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
Patch Set 2:
Thanks for the fix, Quanlong! And laos thanks for fixing that the unnest+view tests are not running in 'core'!
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Jul 2023 12:58:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20274 )
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 31 Jul 2023 05:09:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20274 )
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13660/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Jul 2023 00:25:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20274 )
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20274/2/testdata/workloads/functional-planner/queries/PlannerTest/zipping-unnest.test
File testdata/workloads/functional-planner/queries/PlannerTest/zipping-unnest.test:
http://gerrit.cloudera.org:8080/#/c/20274/2/testdata/workloads/functional-planner/queries/PlannerTest/zipping-unnest.test@296
PS2, Line 296: UNNEST()
> It's strange the parameter for unnest is not visible in the output. Having
Nice catch! I think it's an issue of how we pass the labels of UnnestExpr and how we implement toSql() for it. Filed IMPALA-12324 to track it separatedly.
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sun, 30 Jul 2023 12:59:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20274 )
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
UnnestExpr can be used in a sort tuple which won't have a resolved path.
In such case, there is no parent tuple id so we should not check it in
UnnestExpr.isBoundByTupleIds(). This fixes the NullPointerException.
Tests
- Added fe and e2e tests for sorting columns come from unnest().
- Move test_zipping_unnest_from_view to a dedicated class that only has
the parquet file_format dimension to make sure it also runs in "core"
exploration strategy. Before this it only runs in "exhaustive"
strategy.
Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Reviewed-on: http://gerrit.cloudera.org:8080/20274
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java
M testdata/workloads/functional-planner/queries/PlannerTest/zipping-unnest.test
M testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-from-view.test
M tests/query_test/test_nested_types.py
4 files changed, 257 insertions(+), 7 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Gabor Kaszab, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20274
to look at the new patch set (#3).
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
UnnestExpr can be used in a sort tuple which won't have a resolved path.
In such case, there is no parent tuple id so we should not check it in
UnnestExpr.isBoundByTupleIds(). This fixes the NullPointerException.
Tests
- Added fe and e2e tests for sorting columns come from unnest().
- Move test_zipping_unnest_from_view to a dedicated class that only has
the parquet file_format dimension to make sure it also runs in "core"
exploration strategy. Before this it only runs in "exhaustive"
strategy.
Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
---
M fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java
M testdata/workloads/functional-planner/queries/PlannerTest/zipping-unnest.test
M testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-from-view.test
M tests/query_test/test_nested_types.py
4 files changed, 257 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/20274/3
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20274 )
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
Patch Set 3: Code-Review+2
Carrying +2 from Gabor and Daniel
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 31 Jul 2023 00:47:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20274 )
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9543/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 31 Jul 2023 00:48:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20274 )
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Jul 2023 09:10:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20274 )
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9538/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Jul 2023 02:28:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20274 )
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13671/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sun, 30 Jul 2023 13:22:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/20274 )
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20274/2/testdata/workloads/functional-planner/queries/PlannerTest/zipping-unnest.test
File testdata/workloads/functional-planner/queries/PlannerTest/zipping-unnest.test:
http://gerrit.cloudera.org:8080/#/c/20274/2/testdata/workloads/functional-planner/queries/PlannerTest/zipping-unnest.test@296
PS2, Line 296: UNNEST()
It's strange the parameter for unnest is not visible in the output. Having multiple unnests in the query would make it ambiguous for the reader which one we refer to here.
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Jul 2023 12:57:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20274 )
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13653/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 27 Jul 2023 14:28:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20274 )
Change subject: IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()
......................................................................
Patch Set 2:
(1 comment)
Thanks, added some FE tests.
http://gerrit.cloudera.org:8080/#/c/20274/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20274/1//COMMIT_MSG@10
PS1, Line 10: is
> Nit: is.
Done
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Jul 2023 00:02:50 +0000
Gerrit-HasComments: Yes