You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/06/29 17:44:21 UTC

[GitHub] szha commented on a change in pull request #11466: [MXNET-560] Add temperature parameter in Softmax operator

szha commented on a change in pull request #11466: [MXNET-560] Add temperature parameter in Softmax operator
URL: https://github.com/apache/incubator-mxnet/pull/11466#discussion_r199232911
 
 

 ##########
 File path: src/operator/nn/softmax-inl.h
 ##########
 @@ -53,7 +53,7 @@ struct log_softmax_fwd {
 
 template<typename OP, typename DType, int ndim>
 inline void Softmax(Stream<cpu> *s, DType *in, DType *out,
-                    Shape<ndim> shape, int axis) {
+                    Shape<ndim> shape, int axis, const float temperature) {
 
 Review comment:
   should we support double precision and half precision too?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services