You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "thisisArjit (via GitHub)" <gi...@apache.org> on 2025/07/22 17:53:13 UTC
[PR] [GOBBLIN-XXX] Propagate job properties to Work units [gobblin]
thisisArjit opened a new pull request, #4124:
URL: https://github.com/apache/gobblin/pull/4124
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title.
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Adds fs (file system) properties to temporal job properties
- [ ] Propagates fs properties to Work units
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
- [ ] This PR only passes properties via constructors & getter / setters
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GOBBLIN-2213] Propagate file system job properties to Work unit metadata [gobblin]
Posted by "abhishekmjain (via GitHub)" <gi...@apache.org>.
abhishekmjain commented on code in PR #4124:
URL: https://github.com/apache/gobblin/pull/4124#discussion_r2234598813
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java:
##########
@@ -85,6 +85,9 @@ public ExecGobblinStats execute(Properties jobProps, EventSubmitterContext event
// Filtering only temporal job properties to pass to child workflows to avoid passing unnecessary properties
Review Comment:
nit: please update this comment
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java:
##########
@@ -85,6 +85,9 @@ public ExecGobblinStats execute(Properties jobProps, EventSubmitterContext event
// Filtering only temporal job properties to pass to child workflows to avoid passing unnecessary properties
final Properties temporalJobProps = PropertiesUtils.extractPropertiesWithPrefix(jobProps,
com.google.common.base.Optional.of(GobblinTemporalConfigurationKeys.PREFIX));
+ // Add File system properties to the temporal job properties
Review Comment:
how many properties are getting added as part of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GOBBLIN-2213] Propagate file system job properties to Work unit metadata [gobblin]
Posted by "thisisArjit (via GitHub)" <gi...@apache.org>.
thisisArjit commented on code in PR #4124:
URL: https://github.com/apache/gobblin/pull/4124#discussion_r2234629453
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java:
##########
@@ -85,6 +85,9 @@ public ExecGobblinStats execute(Properties jobProps, EventSubmitterContext event
// Filtering only temporal job properties to pass to child workflows to avoid passing unnecessary properties
final Properties temporalJobProps = PropertiesUtils.extractPropertiesWithPrefix(jobProps,
com.google.common.base.Optional.of(GobblinTemporalConfigurationKeys.PREFIX));
+ // Add File system properties to the temporal job properties
Review Comment:
in total 2 properties will get added, fs.perf-tracking.publish-azkaban-only.enable=false & fs.uri
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GOBBLIN-2213] Propagate file system job properties to Work unit metadata [gobblin]
Posted by "Blazer-007 (via GitHub)" <gi...@apache.org>.
Blazer-007 commented on code in PR #4124:
URL: https://github.com/apache/gobblin/pull/4124#discussion_r2227358125
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/PriorJobStateWUProcessingSpec.java:
##########
@@ -51,8 +52,8 @@ public class PriorJobStateWUProcessingSpec extends WUProcessingSpec {
@NonNull private List<Tag<?>> tags = new ArrayList<>();
@NonNull private String metricsSuffix = GobblinTemporalConfigurationKeys.DEFAULT_GOBBLIN_TEMPORAL_JOB_METRICS_SUFFIX;
- public PriorJobStateWUProcessingSpec(URI fileSystemUri, String workUnitsDir, EventSubmitterContext eventSubmitterContext) {
- super(fileSystemUri, workUnitsDir, eventSubmitterContext);
+ public PriorJobStateWUProcessingSpec(URI fileSystemUri, String workUnitsDir, EventSubmitterContext eventSubmitterContext, Properties jobProps) {
+ super(fileSystemUri, workUnitsDir, eventSubmitterContext, jobProps);
Review Comment:
nit : let's name it `fileSystemProperties` only to keep it consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GOBBLIN-2213] Propagate file system job properties to Work unit metadata [gobblin]
Posted by "thisisArjit (via GitHub)" <gi...@apache.org>.
thisisArjit commented on code in PR #4124:
URL: https://github.com/apache/gobblin/pull/4124#discussion_r2227407588
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/PriorJobStateWUProcessingSpec.java:
##########
@@ -51,8 +52,8 @@ public class PriorJobStateWUProcessingSpec extends WUProcessingSpec {
@NonNull private List<Tag<?>> tags = new ArrayList<>();
@NonNull private String metricsSuffix = GobblinTemporalConfigurationKeys.DEFAULT_GOBBLIN_TEMPORAL_JOB_METRICS_SUFFIX;
- public PriorJobStateWUProcessingSpec(URI fileSystemUri, String workUnitsDir, EventSubmitterContext eventSubmitterContext) {
- super(fileSystemUri, workUnitsDir, eventSubmitterContext);
+ public PriorJobStateWUProcessingSpec(URI fileSystemUri, String workUnitsDir, EventSubmitterContext eventSubmitterContext, Properties jobProps) {
+ super(fileSystemUri, workUnitsDir, eventSubmitterContext, jobProps);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GOBBLIN-2213] Propagate file system job properties to Work unit metadata [gobblin]
Posted by "abhishekmjain (via GitHub)" <gi...@apache.org>.
abhishekmjain merged PR #4124:
URL: https://github.com/apache/gobblin/pull/4124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org