You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/07/19 03:21:09 UTC
Review Request 12753: Added a LIBPROCESS_STATISTICS_WINDOW environment
variable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12753/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Repository: mesos-git
Description
-------
Discarded the old review due to the repository migration: https://reviews.apache.org/r/12601/
Diffs
-----
3rdparty/libprocess/src/process.cpp 08242ced05a2d8004b818b4952194f0aa66b4fcb
Diff: https://reviews.apache.org/r/12753/diff/
Testing
-------
Thanks,
Ben Mahler
Re: Review Request 12753: Added a LIBPROCESS_STATISTICS_WINDOW environment
variable.
Posted by Ben Mahler <be...@gmail.com>.
> On July 19, 2013, 3:48 a.m., Vinod Kone wrote:
> > 3rdparty/libprocess/src/process.cpp, line 588
> > <https://reviews.apache.org/r/12753/diff/1/?file=323597#file323597line588>
> >
> > Why static?
Good catch!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12753/#review23474
-----------------------------------------------------------
On July 19, 2013, 1:21 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12753/
> -----------------------------------------------------------
>
> (Updated July 19, 2013, 1:21 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Discarded the old review due to the repository migration: https://reviews.apache.org/r/12601/
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 08242ced05a2d8004b818b4952194f0aa66b4fcb
>
> Diff: https://reviews.apache.org/r/12753/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 12753: Added a LIBPROCESS_STATISTICS_WINDOW environment
variable.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12753/#review23474
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/12753/#comment47372>
Why static?
- Vinod Kone
On July 19, 2013, 1:21 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12753/
> -----------------------------------------------------------
>
> (Updated July 19, 2013, 1:21 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Discarded the old review due to the repository migration: https://reviews.apache.org/r/12601/
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 08242ced05a2d8004b818b4952194f0aa66b4fcb
>
> Diff: https://reviews.apache.org/r/12753/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 12753: Added a LIBPROCESS_STATISTICS_WINDOW environment
variable.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12753/
-----------------------------------------------------------
(Updated July 19, 2013, 7:17 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Removed static per vinod's review.
Repository: mesos-git
Description
-------
Discarded the old review due to the repository migration: https://reviews.apache.org/r/12601/
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp 08242ced05a2d8004b818b4952194f0aa66b4fcb
Diff: https://reviews.apache.org/r/12753/diff/
Testing
-------
Thanks,
Ben Mahler