You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "KeDeng (Code Review)" <ge...@cloudera.org> on 2025/06/16 09:37:13 UTC
[kudu-CR] Add support for Rocky Linux 9 in build toolchain scripts
KeDeng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23033
Change subject: Add support for Rocky Linux 9 in build toolchain scripts
......................................................................
Add support for Rocky Linux 9 in build toolchain scripts
This commit enables proper C++17 compilation on Rocky Linux 9 by:
1. Adding OS detection for Rocky Linux 9 in enable_devtoolset.sh
2. Implementing a new custom_run_at_rocky9() function that:
- Activates gcc-toolset-12 using /opt/rh/gcc-toolset-12/enable
- Integrates ccache using pre-built wrapper scripts
- Sets CC/CXX environment variables to appropriate compilers
3. Creating ccache wrapper scripts in build-support/ccache-gcc-toolset-12:
- cc: Executes ccache with gcc
- c++: Executes ccache with g++
4. Maintaining backward compatibility with existing RHEL/CentOS 6/7 systems
The changes ensure Kudu can be built on Rocky Linux 9 using gcc-toolset-12
which provides GCC 12.X.X and full C++17 support. The solution follows
the same pattern as existing devtoolset implementations but adapts to
Rocky's gcc-toolset environment.
Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
---
A build-support/ccache-gcc-toolset-12/c++
A build-support/ccache-gcc-toolset-12/cc
M build-support/enable_devtoolset.sh
3 files changed, 76 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/23033/1
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
[kudu-CR] [Rocky] Add support for Rocky Linux in build toolchain scripts
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: [Rocky] Add support for Rocky Linux in build toolchain scripts
......................................................................
Patch Set 6:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/23033/6//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23033/6//COMMIT_MSG@9
PS6, Line 9: proper C++17 compilation on Rocky Linux
I'm not sure I understand why to bring in GC C12 via devtoolset when it's well known that GCC 11 (which is the default system compiler for Rocky Linux 9.5) has full support of the C++17 standard:
https://gcc.gnu.org/projects/cxx-status.html#cxx17
In fact, GCC 8 already had all what's necessary to compile C++17 code, at least it works for Kudu quite well on both RHEL and SUSE Linux distros.
http://gerrit.cloudera.org:8080/#/c/23033/6//COMMIT_MSG@20
PS6, Line 20: Kudu can be built on Rocky Linux using gcc-toolset-12
: which provides GCC 12.X.X and full C++17 support
Kudu can be built even with GCC8/G++8 with C++17 support, and GCC 11 officially has C++17 as default mode:
https://gcc.gnu.org/projects/cxx-status.html#cxx17
Why is this fuss around GCC12 then? What does GCC11/G++11 (that comes as standard C/C++ compiler for Rocky Linux 9.5) miss to have full C++17 support? What's missing there to to succssfully compile Kudu?
http://gerrit.cloudera.org:8080/#/c/23033/6/build-support/ccache-gcc-toolset-12/cc
File build-support/ccache-gcc-toolset-12/cc:
http://gerrit.cloudera.org:8080/#/c/23033/6/build-support/ccache-gcc-toolset-12/cc@19
PS6, Line 19: c++
nit: cc
http://gerrit.cloudera.org:8080/#/c/23033/6/build-support/enable_devtoolset.sh
File build-support/enable_devtoolset.sh:
http://gerrit.cloudera.org:8080/#/c/23033/6/build-support/enable_devtoolset.sh@130
PS6, Line 130: (rocky)
I don't understand why to have 'rocky' in parentheses. I think the following regex is working the same way:
'ID=["]?rocky["]?'
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 25 Jun 2025 17:50:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] Add support for Rocky Linux 9 in build toolchain scripts
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23033
to look at the new patch set (#2).
Change subject: Add support for Rocky Linux 9 in build toolchain scripts
......................................................................
Add support for Rocky Linux 9 in build toolchain scripts
This commit enables proper C++17 compilation on Rocky Linux 9 by:
1. Adding OS detection for Rocky Linux 9 in enable_devtoolset.sh
2. Implementing a new custom_run_at_rocky9() function that:
- Activates gcc-toolset-12 using /opt/rh/gcc-toolset-12/enable
- Integrates ccache using pre-built wrapper scripts
- Sets CC/CXX environment variables to appropriate compilers
3. Creating ccache wrapper scripts in build-support/ccache-gcc-toolset-12:
- cc: Executes ccache with gcc
- c++: Executes ccache with g++
4. Maintaining backward compatibility with existing RHEL/CentOS 6/7 systems
The changes ensure Kudu can be built on Rocky Linux 9 using gcc-toolset-12
which provides GCC 12.X.X and full C++17 support. The solution follows
the same pattern as existing devtoolset implementations but adapts to
Rocky's gcc-toolset environment.
Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
---
A build-support/ccache-gcc-toolset-12/c++
A build-support/ccache-gcc-toolset-12/cc
M build-support/enable_devtoolset.sh
3 files changed, 65 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/23033/2
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Rocky] Add support for Rocky Linux in build toolchain scripts
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: [Rocky] Add support for Rocky Linux in build toolchain scripts
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23033/6//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23033/6//COMMIT_MSG@9
PS6, Line 9: proper C++17 compilation on Rocky Linux
> I'm not sure I understand why to bring in GC C12 via devtoolset when it's w
Hi Alexey,
Thank you very much for your sincere feedback. Kudu has done a great job adapting to RHEL and SUSE-related distributions. In China, most companies used to rely on CentOS. After CentOS reached its end of official support, many have chosen Rocky Linux as a replacement. Although our current customers are still primarily using CentOS and RHEL, it's undeniable that Rocky is becoming an important option for the future.
Rocky 9.5 comes with GCC 11 by default, but during my research I found that the minimum available version of gcc-toolset is gcc-toolset-12. To facilitate future standardization and compatibility work, I intended to standardize the GCC version in this submission to make it easier for other users to compile Kudu moving forward.
Since you feel this change may not be appropriate, let's ignore this submission for now. I sincerely apologize for taking up your time.
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 26 Jun 2025 02:46:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] Add support for Rocky Linux 9 in build toolchain scripts
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: Add support for Rocky Linux 9 in build toolchain scripts
......................................................................
Patch Set 2:
(1 comment)
Overall looks good to me. Just a minor nit.
http://gerrit.cloudera.org:8080/#/c/23033/2/build-support/enable_devtoolset.sh
File build-support/enable_devtoolset.sh:
http://gerrit.cloudera.org:8080/#/c/23033/2/build-support/enable_devtoolset.sh@43
PS2, Line 43: custom_run_at_rocky9
Should we just make it run for any rocky version for now?
There is a likelihood that same rules apply for next version as well.
Later, if we find that build for future version is failing, we can have separate handling for that version.
What do you say?
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Jun 2025 06:01:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] Add support for Rocky Linux 9 in build toolchain scripts
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: Add support for Rocky Linux 9 in build toolchain scripts
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1457/
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Jun 2025 02:34:55 +0000
Gerrit-HasComments: No
[kudu-CR] Add support for Rocky Linux in build toolchain scripts
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: Add support for Rocky Linux in build toolchain scripts
......................................................................
Patch Set 3:
(1 comment)
Thank you for your feedback. The adaptation work is still ongoing – a successful compilation build doesn't guarantee normal testing. I'm actively working on the related debugging efforts."
http://gerrit.cloudera.org:8080/#/c/23033/2/build-support/enable_devtoolset.sh
File build-support/enable_devtoolset.sh:
http://gerrit.cloudera.org:8080/#/c/23033/2/build-support/enable_devtoolset.sh@43
PS2, Line 43: # NOTE: Only test on
> Should we just make it run for any rocky version for now?
Done
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Jun 2025 09:23:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Rocky] Add support for Rocky Linux in build toolchain scripts
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: [Rocky] Add support for Rocky Linux in build toolchain scripts
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23033/4/build-support/enable_devtoolset.sh
File build-support/enable_devtoolset.sh:
http://gerrit.cloudera.org:8080/#/c/23033/4/build-support/enable_devtoolset.sh@53
PS4, Line 53: export CC="/usr/bin/gcc"
: export CXX="/usr/bin/g++"
I'm confused: how this makes sense if there is an attempt to use devtoolset right above at line 46. At least with prior versions of devtoolset on RHEL/CentOS, /usr/bin/gcc and devltoolset were from different toolchains, and mixing those was a no-no.
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Jun 2025 07:26:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Rocky] Add support for Rocky Linux in build toolchain scripts
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: [Rocky] Add support for Rocky Linux in build toolchain scripts
......................................................................
Patch Set 5: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1479/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 5
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Jun 2025 11:23:35 +0000
Gerrit-HasComments: No
[kudu-CR] [Rocky] Add support for Rocky Linux in build toolchain scripts
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: [Rocky] Add support for Rocky Linux in build toolchain scripts
......................................................................
Patch Set 4: Verified+1
Build Successful
http://jenkins.kudu.apache.org/job/pre_commit/1463/ : SUCCESS
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Jun 2025 04:01:56 +0000
Gerrit-HasComments: No
[kudu-CR] [Rocky] Add support for Rocky Linux in build toolchain scripts
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23033
to look at the new patch set (#6).
Change subject: [Rocky] Add support for Rocky Linux in build toolchain scripts
......................................................................
[Rocky] Add support for Rocky Linux in build toolchain scripts
This commit enables proper C++17 compilation on Rocky Linux by:
1. Adding OS detection for Rocky Linux in enable_devtoolset.sh
2. Implementing a new custom_run_at_rocky() function that:
- Activates gcc-toolset-12 using /opt/rh/gcc-toolset-12/enable
- Integrates ccache using pre-built wrapper scripts
- Sets CC/CXX environment variables to appropriate compilers
3. Creating ccache wrapper scripts in build-support/ccache-gcc-toolset-12:
- cc: Executes ccache with gcc
- c++: Executes ccache with g++
4. Maintaining backward compatibility with existing RHEL/CentOS 6/7 systems
The changes ensure Kudu can be built on Rocky Linux using gcc-toolset-12
which provides GCC 12.X.X and full C++17 support. The solution follows
the same pattern as existing devtoolset implementations but adapts to
Rocky's gcc-toolset environment.
Finally, note that this has currently only been tested on Rocky Linux 9.
If issues arise with other Rocky Linux versions in the future, they may
need to be addressed specifically.
Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
---
A build-support/ccache-gcc-toolset-12/c++
A build-support/ccache-gcc-toolset-12/cc
M build-support/enable_devtoolset.sh
3 files changed, 61 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/23033/6
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Rocky] Add support for Rocky Linux in build toolchain scripts
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: [Rocky] Add support for Rocky Linux in build toolchain scripts
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23033/2/build-support/enable_devtoolset.sh
File build-support/enable_devtoolset.sh:
http://gerrit.cloudera.org:8080/#/c/23033/2/build-support/enable_devtoolset.sh@43
PS2, Line 43: # NOTE: Only test on
> I think there is some confusion. I meant would it be possible to run this f
Sorry for previously misunderstanding your point — I thought you meant to add version recognition later when encountering new versions. I've now updated the code according to your suggestion. Thanks a lot for your review and feedback!
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Jun 2025 02:51:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Rocky] Add support for Rocky Linux in build toolchain scripts
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23033
to look at the new patch set (#5).
Change subject: [Rocky] Add support for Rocky Linux in build toolchain scripts
......................................................................
[Rocky] Add support for Rocky Linux in build toolchain scripts
This commit enables proper C++17 compilation on Rocky Linux by:
1. Adding OS detection for Rocky Linux in enable_devtoolset.sh
2. Implementing a new custom_run_at_rocky9() function that:
- Activates gcc-toolset-12 using /opt/rh/gcc-toolset-12/enable
- Integrates ccache using pre-built wrapper scripts
- Sets CC/CXX environment variables to appropriate compilers
3. Creating ccache wrapper scripts in build-support/ccache-gcc-toolset-12:
- cc: Executes ccache with gcc
- c++: Executes ccache with g++
4. Maintaining backward compatibility with existing RHEL/CentOS 6/7 systems
The changes ensure Kudu can be built on Rocky Linux using gcc-toolset-12
which provides GCC 12.X.X and full C++17 support. The solution follows
the same pattern as existing devtoolset implementations but adapts to
Rocky's gcc-toolset environment.
Finally, note that this has currently only been tested on Rocky Linux 9.
If issues arise with other Rocky Linux versions in the future, they may
need to be addressed specifically.
Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
---
A build-support/ccache-gcc-toolset-12/c++
A build-support/ccache-gcc-toolset-12/cc
M build-support/enable_devtoolset.sh
3 files changed, 61 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/23033/5
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 5
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Add support for Rocky Linux in build toolchain scripts
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: Add support for Rocky Linux in build toolchain scripts
......................................................................
Patch Set 3: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1460/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Jun 2025 10:43:44 +0000
Gerrit-HasComments: No
[kudu-CR] Add support for Rocky Linux 9 in build toolchain scripts
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: Add support for Rocky Linux 9 in build toolchain scripts
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1451/
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Jun 2025 09:37:21 +0000
Gerrit-HasComments: No
[kudu-CR] Add support for Rocky Linux 9 in build toolchain scripts
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: Add support for Rocky Linux 9 in build toolchain scripts
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/23033/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23033/1//COMMIT_MSG@12
PS1, Line 12: gcc-toolset-12
> This would be an additional prerequisite for Rocky linux. Maybe after this,
Yes, the documentation updates are on my to-do list. I will update the installation documentation after completing all relevant adaptations and testing to prevent inaccuracies.
http://gerrit.cloudera.org:8080/#/c/23033/1/build-support/enable_devtoolset.sh
File build-support/enable_devtoolset.sh:
http://gerrit.cloudera.org:8080/#/c/23033/1/build-support/enable_devtoolset.sh@136
PS1, Line 136: elif g
> What if RHEL or CentOS version is 9?
Thanks for the reminder, I shouldn't have mixed up the operating system and version numbers. I've updated that section of the code now.
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Jun 2025 02:35:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] Add support for Rocky Linux 9 in build toolchain scripts
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: Add support for Rocky Linux 9 in build toolchain scripts
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/23033/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23033/1//COMMIT_MSG@12
PS1, Line 12: gcc-toolset-12
This would be an additional prerequisite for Rocky linux. Maybe after this, installation webpage (https://kudu.apache.org/docs/installation.html) also needs to be updated to reflect the additional requirement.
http://gerrit.cloudera.org:8080/#/c/23033/1/build-support/enable_devtoolset.sh
File build-support/enable_devtoolset.sh:
http://gerrit.cloudera.org:8080/#/c/23033/1/build-support/enable_devtoolset.sh@136
PS1, Line 136: 9)
What if RHEL or CentOS version is 9?
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Jun 2025 15:05:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] Add support for Rocky Linux in build toolchain scripts
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23033
to look at the new patch set (#3).
Change subject: Add support for Rocky Linux in build toolchain scripts
......................................................................
Add support for Rocky Linux in build toolchain scripts
This commit enables proper C++17 compilation on Rocky Linux by:
1. Adding OS detection for Rocky Linux in enable_devtoolset.sh
2. Implementing a new custom_run_at_rocky9() function that:
- Activates gcc-toolset-12 using /opt/rh/gcc-toolset-12/enable
- Integrates ccache using pre-built wrapper scripts
- Sets CC/CXX environment variables to appropriate compilers
3. Creating ccache wrapper scripts in build-support/ccache-gcc-toolset-12:
- cc: Executes ccache with gcc
- c++: Executes ccache with g++
4. Maintaining backward compatibility with existing RHEL/CentOS 6/7 systems
The changes ensure Kudu can be built on Rocky Linux using gcc-toolset-12
which provides GCC 12.X.X and full C++17 support. The solution follows
the same pattern as existing devtoolset implementations but adapts to
Rocky's gcc-toolset environment.
Finally, note that this has currently only been tested on Rocky Linux 9.
If issues arise with other Rocky Linux versions in the future, they may need to be addressed specifically.
Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
---
A build-support/ccache-gcc-toolset-12/c++
A build-support/ccache-gcc-toolset-12/cc
M build-support/enable_devtoolset.sh
3 files changed, 65 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/23033/3
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Add support for Rocky Linux in build toolchain scripts
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: Add support for Rocky Linux in build toolchain scripts
......................................................................
Patch Set 3:
(1 comment)
> Patch Set 3:
>
> (1 comment)
>
> Thank you for your feedback. The adaptation work is still ongoing – a successful compilation build doesn't guarantee normal testing. I'm actively working on the related debugging efforts."
I agree. I pointed out the failures to ensure that these failures are not related to current change itself. If that is not the case, I am fine with resolving these issues in subsequent patches.
http://gerrit.cloudera.org:8080/#/c/23033/2/build-support/enable_devtoolset.sh
File build-support/enable_devtoolset.sh:
http://gerrit.cloudera.org:8080/#/c/23033/2/build-support/enable_devtoolset.sh@43
PS2, Line 43: # NOTE: Only test on
> Done
I think there is some confusion. I meant would it be possible to run this for every rocky version instead of just version 9. For that, you would need to make changes at line 120 and 134 by not including '9' in grep search and call custom_run_at_rocky for any rocky version?
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Jun 2025 12:07:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Rocky] Add support for Rocky Linux in build toolchain scripts
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: [Rocky] Add support for Rocky Linux in build toolchain scripts
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23033/4/build-support/enable_devtoolset.sh
File build-support/enable_devtoolset.sh:
http://gerrit.cloudera.org:8080/#/c/23033/4/build-support/enable_devtoolset.sh@53
PS4, Line 53:
: # Execute the arguments.
> I'm confused: how this makes sense if there is an attempt to use devtoolset
Thanks for the heads-up. I removed that part of the code following the approach in enable_devtoolset_inner.sh.
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 5
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Jun 2025 09:21:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] Add support for Rocky Linux 9 in build toolchain scripts
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: Add support for Rocky Linux 9 in build toolchain scripts
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1457/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Jun 2025 04:02:10 +0000
Gerrit-HasComments: No
[kudu-CR] [Rocky] Add support for Rocky Linux in build toolchain scripts
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has abandoned this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: [Rocky] Add support for Rocky Linux in build toolchain scripts
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Rocky] Add support for Rocky Linux in build toolchain scripts
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: [Rocky] Add support for Rocky Linux in build toolchain scripts
......................................................................
Patch Set 6:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1506/
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 25 Jun 2025 07:51:08 +0000
Gerrit-HasComments: No
[kudu-CR] [Rocky] Add support for Rocky Linux in build toolchain scripts
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: [Rocky] Add support for Rocky Linux in build toolchain scripts
......................................................................
Patch Set 6: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1506/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 25 Jun 2025 09:31:09 +0000
Gerrit-HasComments: No
[kudu-CR] Add support for Rocky Linux 9 in build toolchain scripts
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: Add support for Rocky Linux 9 in build toolchain scripts
......................................................................
Patch Set 1: Verified+1
Build Successful
http://jenkins.kudu.apache.org/job/pre_commit/1451/ : SUCCESS
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Jun 2025 10:26:52 +0000
Gerrit-HasComments: No
[kudu-CR] [Rocky] Add support for Rocky Linux in build toolchain scripts
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: [Rocky] Add support for Rocky Linux in build toolchain scripts
......................................................................
Patch Set 5:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1479/
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 5
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Jun 2025 09:21:51 +0000
Gerrit-HasComments: No
[kudu-CR] Add support for Rocky Linux 9 in build toolchain scripts
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: Add support for Rocky Linux 9 in build toolchain scripts
......................................................................
Patch Set 2:
> Patch Set 2:
>
> (1 comment)
>
> Overall looks good to me. Just a minor nit.
I was able to do a debug build successfully on Rocky Linux 9.4 after installing following packages (that are additional to what is listed for RHEL/CentOS):
gcc-toolset-12
krb5-devel
perl-FindBin
However, I see a bunch of test failures for debug build. Not sure if those are related. Could be related to default versions of prerequisite libraries. You might want to take a look at those.
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Jun 2025 09:09:08 +0000
Gerrit-HasComments: No
[kudu-CR] Add support for Rocky Linux in build toolchain scripts
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: Add support for Rocky Linux in build toolchain scripts
......................................................................
Patch Set 3:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1460/
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Jun 2025 09:18:56 +0000
Gerrit-HasComments: No
[kudu-CR] [Rocky] Add support for Rocky Linux in build toolchain scripts
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: [Rocky] Add support for Rocky Linux in build toolchain scripts
......................................................................
Patch Set 4:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1463/
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Jun 2025 02:49:40 +0000
Gerrit-HasComments: No
[kudu-CR] [Rocky] Add support for Rocky Linux in build toolchain scripts
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: [Rocky] Add support for Rocky Linux in build toolchain scripts
......................................................................
Patch Set 4: Code-Review+1
Thank you for addressing the comments.
Looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Jun 2025 05:42:22 +0000
Gerrit-HasComments: No
[kudu-CR] [Rocky] Add support for Rocky Linux in build toolchain scripts
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23033
to look at the new patch set (#4).
Change subject: [Rocky] Add support for Rocky Linux in build toolchain scripts
......................................................................
[Rocky] Add support for Rocky Linux in build toolchain scripts
This commit enables proper C++17 compilation on Rocky Linux by:
1. Adding OS detection for Rocky Linux in enable_devtoolset.sh
2. Implementing a new custom_run_at_rocky9() function that:
- Activates gcc-toolset-12 using /opt/rh/gcc-toolset-12/enable
- Integrates ccache using pre-built wrapper scripts
- Sets CC/CXX environment variables to appropriate compilers
3. Creating ccache wrapper scripts in build-support/ccache-gcc-toolset-12:
- cc: Executes ccache with gcc
- c++: Executes ccache with g++
4. Maintaining backward compatibility with existing RHEL/CentOS 6/7 systems
The changes ensure Kudu can be built on Rocky Linux using gcc-toolset-12
which provides GCC 12.X.X and full C++17 support. The solution follows
the same pattern as existing devtoolset implementations but adapts to
Rocky's gcc-toolset environment.
Finally, note that this has currently only been tested on Rocky Linux 9.
If issues arise with other Rocky Linux versions in the future, they may
need to be addressed specifically.
Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
---
A build-support/ccache-gcc-toolset-12/c++
A build-support/ccache-gcc-toolset-12/cc
M build-support/enable_devtoolset.sh
3 files changed, 64 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/23033/4
--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)