You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2019/05/07 02:34:01 UTC

[jira] [Commented] (PHOENIX-3413) Ineffective null check in LiteralExpression#newConstant()

    [ https://issues.apache.org/jira/browse/PHOENIX-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834328#comment-16834328 ] 

Hudson commented on PHOENIX-3413:
---------------------------------

FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.4 #136 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-1.4/136/])
PHOENIX-3413 Ineffective null check in LiteralExpression#newConstant() (tdsilva: rev 512cbb3fb5c405f6958c0c932d70a28b98729a60)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/LiteralExpression.java


> Ineffective null check in LiteralExpression#newConstant()
> ---------------------------------------------------------
>
>                 Key: PHOENIX-3413
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3413
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.9.1
>            Reporter: Ted Yu
>            Assignee: Kevin Liew
>            Priority: Minor
>             Fix For: 4.15.0, 5.1.0, 4.14.2
>
>         Attachments: PHOENIX-3413.2.patch, PHOENIX-3413.3.patch, PHOENIX-3413.patch
>
>
> {code}
>         if (maxLength == null) {
>             maxLength = type == null || !type.isFixedWidth() ? null : type.getMaxLength(value);
>         }
> {code}
> The null check for type is ineffective - type is de-referenced in various places prior to the above check.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)