You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by de...@apache.org on 2016/10/17 18:27:08 UTC

svn commit: r1765348 - in /ofbiz/trunk/applications/accounting: minilang/ledger/GeneralLedgerServices.xml servicedef/services_ledger.xml

Author: deepak
Date: Mon Oct 17 18:27:07 2016
New Revision: 1765348

URL: http://svn.apache.org/viewvc?rev=1765348&view=rev
Log:
Improved: Convert GlJournal entity related CRUD services from simple to entity-auto.
(OFBIZ-8381)(OFBIZ-8382)(OFBIZ-8383)

Thanks Pawan Verma for your contribution.

Modified:
    ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml
    ofbiz/trunk/applications/accounting/servicedef/services_ledger.xml

Modified: ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml?rev=1765348&r1=1765347&r2=1765348&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml (original)
+++ ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml Mon Oct 17 18:27:07 2016
@@ -85,26 +85,6 @@ under the License.
         <field-to-result field="acctgTransId" result-name="acctgTransId"/>
     </simple-method>
 
-    <simple-method method-name="createGlJournal" short-description="Create an GlJournal">
-        <make-value entity-name="GlJournal" value-field="newEntity"/>
-        <set-nonpk-fields map="parameters" value-field="newEntity"/>
-
-        <!-- GlJournal uses a sequenced id, so get the next one now and set it... -->
-        <sequenced-id sequence-name="GlJournal" field="newEntity.glJournalId"/>
-        <field-to-result field="newEntity.glJournalId" result-name="glJournalId"/>
-
-        <create-value value-field="newEntity"/>
-    </simple-method>
-    <simple-method method-name="updateGlJournal" short-description="Update an GlJournal">
-        <entity-one entity-name="GlJournal" value-field="lookedUpValue"/>
-        <set-nonpk-fields map="parameters" value-field="lookedUpValue"/>
-        <store-value value-field="lookedUpValue"/>
-    </simple-method>
-    <simple-method method-name="deleteGlJournal" short-description="Delete an GlJournal">
-        <entity-one entity-name="GlJournal" value-field="lookedUpValue"/>
-        <remove-value value-field="lookedUpValue"/>
-    </simple-method>
-
     <!-- GlJournal Trial Balance and Post routines -->
     <simple-method method-name="calculateGlJournalTrialBalance" short-description="Calculate Trial Balance for a GlJournal">
         <!-- iterate through all AcctgTrans in this journal and that are not yet posted, and get totals of all debits and of all credits -->

Modified: ofbiz/trunk/applications/accounting/servicedef/services_ledger.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/services_ledger.xml?rev=1765348&r1=1765347&r2=1765348&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/servicedef/services_ledger.xml (original)
+++ ofbiz/trunk/applications/accounting/servicedef/services_ledger.xml Mon Oct 17 18:27:07 2016
@@ -99,8 +99,7 @@ under the License.
         <description>Post a GlJournal</description>
         <auto-attributes include="pk" mode="IN" optional="false"/>
     </service>
-    <service name="createGlJournal" default-entity-name="GlJournal" engine="simple"
-            location="component://accounting/minilang/ledger/GeneralLedgerServices.xml" invoke="createGlJournal" auth="true">
+    <service name="createGlJournal" default-entity-name="GlJournal" engine="entity-auto" invoke="create" auth="true">
         <description>Create a GlJournal record</description>
         <permission-service service-name="basicGeneralLedgerPermissionCheck" main-action="CREATE"/>
         <auto-attributes include="pk" mode="OUT" optional="false"/>
@@ -110,8 +109,7 @@ under the License.
         </auto-attributes>
         <override name="organizationPartyId" optional="false"/>
     </service>
-    <service name="updateGlJournal" default-entity-name="GlJournal" engine="simple"
-            location="component://accounting/minilang/ledger/GeneralLedgerServices.xml" invoke="updateGlJournal" auth="true">
+    <service name="updateGlJournal" default-entity-name="GlJournal" engine="entity-auto" invoke="update" auth="true">
         <description>Update a GlJournal record</description>
         <permission-service service-name="basicGeneralLedgerPermissionCheck" main-action="UPDATE"/>
         <auto-attributes include="pk" mode="IN" optional="false"/>
@@ -120,8 +118,7 @@ under the License.
             <exclude field-name="postedDate"/>
         </auto-attributes>
     </service>
-    <service name="deleteGlJournal" default-entity-name="GlJournal" engine="simple"
-            location="component://accounting/minilang/ledger/GeneralLedgerServices.xml" invoke="deleteGlJournal" auth="true">
+    <service name="deleteGlJournal" default-entity-name="GlJournal" engine="entity-auto" invoke="delete" auth="true">
         <description>Delete a GlJournal record</description>
         <permission-service service-name="basicGeneralLedgerPermissionCheck" main-action="DELETE"/>
         <auto-attributes include="pk" mode="IN" optional="false"/>