You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/19 08:11:28 UTC

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9813: labeled avg in OAL

wu-sheng commented on code in PR #9813:
URL: https://github.com/apache/skywalking/pull/9813#discussion_r999090982


##########
oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/parser/DeepAnalysis.java:
##########
@@ -81,9 +82,10 @@ public AnalysisResult analysis(AnalysisResult result) {
         EntryMethod entryMethod = new EntryMethod();
         result.setEntryMethod(entryMethod);
         entryMethod.setMethodName(entranceMethod.getName());
-
+        final Parameter[] parameters = entranceMethod.getParameters();
         // 4. Use parameter's annotation of entrance method to generate aggregation entrance.
-        for (Parameter parameter : entranceMethod.getParameters()) {
+        for (int i = 0; i < parameters.length; i++) {
+            Parameter parameter = parameters[i];

Review Comment:
   Why change this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org