You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "cmcfarlen (via GitHub)" <gi...@apache.org> on 2024/04/26 20:18:27 UTC
[PR] Restore derived metrics using new metrics [trafficserver]
cmcfarlen opened a new pull request, #11297:
URL: https://github.com/apache/trafficserver/pull/11297
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore derived metrics using new metrics [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #11297:
URL: https://github.com/apache/trafficserver/pull/11297#discussion_r1583243580
##########
include/tsutil/Metrics.h:
##########
@@ -506,6 +507,18 @@ class Metrics
}; // class Counter
+ class Derived
+ {
Review Comment:
Let's add doxygen comments explaining the responsibilities and purpose of this class.
##########
include/tsutil/Metrics.h:
##########
@@ -506,6 +507,18 @@ class Metrics
}; // class Counter
+ class Derived
+ {
+ public:
+ struct DerivedMetricSpec {
+ std::string_view derived_name;
+ std::initializer_list<std::variant<Metrics::AtomicType *, Metrics::IdType, std::string_view>> derived_from;
+ };
+
+ static void derive(const std::initializer_list<DerivedMetricSpec> &metrics);
+ static void update_derived();
Review Comment:
doxygen
##########
include/tsutil/Metrics.h:
##########
@@ -506,6 +507,18 @@ class Metrics
}; // class Counter
+ class Derived
+ {
+ public:
+ struct DerivedMetricSpec {
+ std::string_view derived_name;
+ std::initializer_list<std::variant<Metrics::AtomicType *, Metrics::IdType, std::string_view>> derived_from;
Review Comment:
A using alias for the variant could be helpful here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore derived metrics using new metrics [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #11297:
URL: https://github.com/apache/trafficserver/pull/11297#issuecomment-2088581632
Cherry-picked to v10.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore derived metrics using new metrics [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen merged PR #11297:
URL: https://github.com/apache/trafficserver/pull/11297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore derived metrics using new metrics [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #11297:
URL: https://github.com/apache/trafficserver/pull/11297#issuecomment-2083773439
https://github.com/apache/trafficserver/blob/9.2.x/mgmt/DerivativeMetrics.cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org