You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2023/05/26 07:15:26 UTC
[GitHub] [kyuubi] turboFei opened a new pull request, #4889: Admin command line supports list server
turboFei opened a new pull request, #4889:
URL: https://github.com/apache/kyuubi/pull/4889
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #4889: Admin command line supports list server command
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4889:
URL: https://github.com/apache/kyuubi/pull/4889#issuecomment-1565784783
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/4889?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4889](https://app.codecov.io/gh/apache/kyuubi/pull/4889?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0a01315) into [master](https://app.codecov.io/gh/apache/kyuubi/commit/aee9b946f3565c0df9287c0a916b12dad1d3fdce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (aee9b94) will **not change** coverage.
> The diff coverage is `0.00%`.
> :exclamation: Current head 0a01315 differs from pull request most recent head bfd13fb. Consider uploading reports for the commit bfd13fb to get more accurate results
```diff
@@ Coverage Diff @@
## master #4889 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 556 557 +1
Lines 30697 30690 -7
Branches 4000 3996 -4
======================================
+ Misses 30697 30690 -7
```
| [Impacted Files](https://app.codecov.io/gh/apache/kyuubi/pull/4889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/ctl/cli/AdminControlCliArguments.scala](https://app.codecov.io/gh/apache/kyuubi/pull/4889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvY2xpL0FkbWluQ29udHJvbENsaUFyZ3VtZW50cy5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...e/kyuubi/ctl/cmd/list/AdminListServerCommand.scala](https://app.codecov.io/gh/apache/kyuubi/pull/4889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvY21kL2xpc3QvQWRtaW5MaXN0U2VydmVyQ29tbWFuZC5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...a/org/apache/kyuubi/ctl/opt/AdminCommandLine.scala](https://app.codecov.io/gh/apache/kyuubi/pull/4889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvb3B0L0FkbWluQ29tbWFuZExpbmUuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...main/scala/org/apache/kyuubi/ctl/util/Render.scala](https://app.codecov.io/gh/apache/kyuubi/pull/4889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvdXRpbC9SZW5kZXIuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...in/java/org/apache/kyuubi/client/AdminRestApi.java](https://app.codecov.io/gh/apache/kyuubi/pull/4889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L0FkbWluUmVzdEFwaS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/kyuubi/client/api/v1/dto/ServerData.java](https://app.codecov.io/gh/apache/kyuubi/pull/4889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L2FwaS92MS9kdG8vU2VydmVyRGF0YS5qYXZh) | `0.00% <0.00%> (ø)` | |
... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/kyuubi/pull/4889/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei closed pull request #4889: Admin command line supports list server command
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei closed pull request #4889: Admin command line supports list server command
URL: https://github.com/apache/kyuubi/pull/4889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on pull request #4889: Admin command line supports list server command
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #4889:
URL: https://github.com/apache/kyuubi/pull/4889#issuecomment-1565786260
merged to master, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4889: Admin command line supports list server command
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4889:
URL: https://github.com/apache/kyuubi/pull/4889#discussion_r1208019413
##########
kyuubi-ctl/src/main/scala/org/apache/kyuubi/ctl/util/Render.scala:
##########
@@ -45,6 +45,19 @@ private[ctl] object Render {
Tabulator.format(title, header, rows)
}
+ def renderServerNodesInfo(serverNodesInfo: Seq[ServerData]): String = {
+ val title = s"Server Node List (total ${serverNodesInfo.size})"
+ val header = Array("Namespace", "Instance", "Attributes", "Status")
+ val rows = serverNodesInfo.map { server =>
+ Array(
+ server.getNamespace,
+ server.getInstance,
+ server.getAttributes.asScala.map(kv => kv._1 + "=" + kv._2).mkString("\n"),
Review Comment:
```suggestion
server.getAttributes.asScala.map { case (k, v) => s"$k=$v").mkString("\n"),
```
##########
kyuubi-ctl/src/main/scala/org/apache/kyuubi/ctl/util/Render.scala:
##########
@@ -45,6 +45,19 @@ private[ctl] object Render {
Tabulator.format(title, header, rows)
}
+ def renderServerNodesInfo(serverNodesInfo: Seq[ServerData]): String = {
+ val title = s"Server Node List (total ${serverNodesInfo.size})"
+ val header = Array("Namespace", "Instance", "Attributes", "Status")
+ val rows = serverNodesInfo.map { server =>
+ Array(
+ server.getNamespace,
+ server.getInstance,
+ server.getAttributes.asScala.map(kv => kv._1 + "=" + kv._2).mkString("\n"),
Review Comment:
```suggestion
server.getAttributes.asScala.map { case (k, v) => s"$k=$v" }.mkString("\n"),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on pull request #4889: Admin command line supports list server command
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #4889:
URL: https://github.com/apache/kyuubi/pull/4889#issuecomment-1563982635
cc @zwangsheng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on pull request #4889: Admin command line supports list server command
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #4889:
URL: https://github.com/apache/kyuubi/pull/4889#issuecomment-1564273068
tests passed @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org