You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <de...@bloodhound.apache.org> on 2014/02/11 20:49:28 UTC

[Apache Bloodhound] #754: Possible unresolved reference in trac.resource

#754: Possible unresolved reference in trac.resource
---------------------+--------------------
  Reporter:  olemis  |    Owner:
      Type:  defect  |   Status:  new
  Priority:  major   |  Version:  0.8.0dev
Resolution:          |
---------------------+--------------------
 In `trac.resource:ResourceSystem`, there is a method
 `get_known_neighborhoods`. It doesn't appear to be used anywhere so it is
 probably not causing any trouble, but there is an unresolved reference
 "manager":

 {{{#!python

     def get_known_neighborhoods(self):
         """Return a list of all the realm names of neighborhoods."""
         realms = []
         for connector in self.resource_connectors:
             for realm in manager.get_supported_neighborhoods() or []:
                 realms.append(realm)
         return realms
 }}}

 It seems like we should either fix it or remove the code, in case someone
 tries to utilize the method.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/754>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #754: Possible unresolved reference in trac.resource

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#754: Possible unresolved reference in trac.resource
------------------------+-----------------------
  Reporter:  olemis     |      Owner:  olemis
      Type:  defect     |     Status:  new
  Priority:  minor      |  Milestone:  Release 8
 Component:  trac core  |    Version:  0.8.0dev
Resolution:             |   Keywords:  resource
------------------------+-----------------------
Changes (by rjollos):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 Somehow I managed to capture only half of the patch in [1567417]. Anyway,
 I have some additional refactoring of the `trac.resource` module to push
 first.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/754#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #754: Possible unresolved reference in trac.resource

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#754: Possible unresolved reference in trac.resource
------------------------+-----------------------
  Reporter:  olemis     |      Owner:  rjollos
      Type:  defect     |     Status:  closed
  Priority:  minor      |  Milestone:  Release 8
 Component:  trac core  |    Version:  0.8.0dev
Resolution:  fixed      |   Keywords:  resource
------------------------+-----------------------
Changes (by rjollos):

 * status:  review => closed
 * resolution:   => fixed


Comment:

 (In [1567417])

 0.8dev: Fix unresolved reference in
 `trac.resource:ResourceSystem.get_known_neighborhoods`. Fixes #754.

 Patch by Olemis.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/754#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #754: Possible unresolved reference in trac.resource

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#754: Possible unresolved reference in trac.resource
------------------------+-----------------------
  Reporter:  olemis     |      Owner:  rjollos
      Type:  defect     |     Status:  review
  Priority:  minor      |  Milestone:  Release 8
 Component:  trac core  |    Version:  0.8.0dev
Resolution:             |   Keywords:  resource
------------------------+-----------------------
Changes (by olemis):

 * owner:  olemis => rjollos
 * status:  accepted => review
 * component:  dashboard => trac core


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/754#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #754: Possible unresolved reference in trac.resource

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#754: Possible unresolved reference in trac.resource
------------------------+-----------------------
  Reporter:  olemis     |      Owner:  olemis
      Type:  defect     |     Status:  accepted
  Priority:  minor      |  Milestone:  Release 8
 Component:  dashboard  |    Version:  0.8.0dev
Resolution:             |   Keywords:  resource
------------------------+-----------------------
Changes (by olemis):

 * status:  new => accepted
 * component:   => dashboard
 * priority:  major => minor
 * keywords:   => resource
 * milestone:   => Release 8
 * owner:   => olemis


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/754#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #754: Possible unresolved reference in trac.resource

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#754: Possible unresolved reference in trac.resource
------------------------+-----------------------
  Reporter:  olemis     |      Owner:  olemis
      Type:  defect     |     Status:  closed
  Priority:  minor      |  Milestone:  Release 8
 Component:  trac core  |    Version:  0.8.0dev
Resolution:  fixed      |   Keywords:  resource
------------------------+-----------------------
Changes (by rjollos):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 (In [1574210])

 Part of r1567417. Refs #754.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/754#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #754: Possible unresolved reference in trac.resource

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#754: Possible unresolved reference in trac.resource
------------------------+-----------------------
  Reporter:  olemis     |      Owner:  olemis
      Type:  defect     |     Status:  closed
  Priority:  minor      |  Milestone:  Release 8
 Component:  trac core  |    Version:  0.8.0dev
Resolution:  fixed      |   Keywords:  resource
------------------------+-----------------------
Changes (by rjollos):

 * owner:  rjollos => olemis


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/754#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #754: Possible unresolved reference in trac.resource

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#754: Possible unresolved reference in trac.resource
------------------------+-----------------------
  Reporter:  olemis     |      Owner:  olemis
      Type:  defect     |     Status:  accepted
  Priority:  minor      |  Milestone:  Release 8
 Component:  dashboard  |    Version:  0.8.0dev
Resolution:             |   Keywords:  resource
------------------------+-----------------------

Comment (by olemis):

 Please review attached patch

 {{{#!sh

 $ hg qapplied
 t754/t754_r1563594_nbh_novar.diff

 $ hg log -r qparent --template="{svnrev}\n"
 1563594
 }}}

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/754#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker