[GitHub] [ozone] vivekratnavel commented on a change in pull request #2506: HDDS-5054. Merge SCM HA configs to ScmConfigKeys.

[GitBox <gi...@apache.org>]

vivekratnavel commented on a change in pull request #2506:
URL: https://github.com/apache/ozone/pull/2506#discussion_r684383897



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
##########
@@ -475,6 +475,71 @@
       OZONE_SCM_EVENT_PREFIX + "ContainerReport.thread.pool.size";
   public static final int OZONE_SCM_EVENT_THREAD_POOL_SIZE_DEFAULT = 10;
 
+  public static final String RATIS_RPC_TYPE =

Review comment:
       Can we add appropriate prefixes to identify the keys easier?
   
   For instance, this can be renamed to `OZONE_SCM_HA_RATIS_RPC_TYPE`. All the other configs can also be prefixed with "OZONE_SCM_HA" 

##########
File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/ha/TestSCMHAConfiguration.java
##########
@@ -60,26 +60,17 @@ public void setup() {
 
   @Test
   public void testSetStorageDir() {
-    SCMHAConfiguration scmhaConfiguration = conf.getObject(
-        SCMHAConfiguration.class);
-    scmhaConfiguration.setRatisStorageDir("scm-ratis");
-    conf.setFromObject(scmhaConfiguration);
-
-    scmhaConfiguration = conf.getObject(
-        SCMHAConfiguration.class);
-    Assert.assertEquals("scm-ratis", scmhaConfiguration.getRatisStorageDir());
+    conf.set(ScmConfigKeys.RATIS_STORAGE_DIR, "scm-ratis");

Review comment:
       We can remove these tests as they aren't meaningful.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org