[GitHub] [flink] tillrohrmann commented on a change in pull request #9940: [FLINK-14434][coordination] Dispatcher#createJobManagerRunner returns on creation succeed

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #9940: [FLINK-14434][coordination] Dispatcher#createJobManagerRunner returns on creation succeed
URL: https://github.com/apache/flink/pull/9940#discussion_r337013493
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
 ##########
 @@ -362,6 +362,7 @@ private boolean isPartialResourceConfigured(JobGraph jobGraph) {
 		jobManagerRunnerFutures.put(jobGraph.getJobID(), jobManagerRunnerFuture);
 
 		return jobManagerRunnerFuture
+			.thenApply(FunctionUtils.uncheckedFunction(this::startJobManagerRunner))
 
 Review comment:
   This change causes a slight semantic change. Before `jobManagerRunnerFutures` contained only a completed `JobManagerRunner` if the `JobManagerRunner` was actually running. This is now no longer true. Hence it could happen that the `Dispatcher` receives a request for a job which then being forwarded to the not yet started `JobMaster`.
   
   In order to solve this problem and the one you are solving here, we could move the registration of the `JobManagerRunner#getResultFuture` to here but leave the starting in `createJobManagerRunner`. Wdyt?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services