[jira] [Commented] (OFBIZ-6976) Updating data sets

["Michael Brohl (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278961#comment-17278961 ] 

Michael Brohl commented on OFBIZ-6976:
--------------------------------------

How should we handle this issue and it's subtasks? I see several problems:
 * The linked PR ([https://github.com/apache/ofbiz-framework/pull/117)] contains a lot of commits, everything is mixed together instead having separate PR's for each subtask.
 * There's no documentation or explanation why changes are made.
 * there's new data introduced but there are no corresponding tests
 * The PR itself has issues and does not merge.

This is a nightmare to review and merge and it seems that the PR is not maintained anymore.

I tend to close this as "Won't do", what do you think?

> Updating data sets
> ------------------
>
>                 Key: OFBIZ-6976
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6976
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS, ALL PLUGINS
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>            Priority: Major
>              Labels: Demo, configuration, data, test
>         Attachments: ORRTIZ-OFBiz-6976.pdf
>
>
> This is a placeholder issue.
> Having correct data shipped with OFBiz is key to not only
>  # have a good operational state (meaning adopters can work with OFBiz out of the box)
>  # have a good data set for demonstration purposes
>  # have a good data set to enable unit, system integration and acceptance testing
> Re aspect 1:
>  This encompasses all security, system property and other seed data sets
> Re aspect 2:
>  This encompasses all data records in the various DemoData.xml files. This kind of data needs to be coherent from the perspective of the main internal organisation (or the legal demo party) that operates the OFBiz implementation.
> Re aspect 3:
>  The data set for this aspect encompasses all data under aspect 1 and 2.
> With a good data set for demonstration purposes it is easier for potential adopters (and their influencers) to see the added value of implementing OFBiz in their company/organisation, while at the same time it helps developers to understand the coherence between widgets, templates, services, functions and other data counter parts. Also, good demo data helps contributors to identity issues regarding the usability of OFBiz, work to resolve them and ultimate improve OFBiz.
> Demo data sets should be grouped in accordance to the component load order (as defined in e.g. component-load.xml, see links below). The first appearance of a data record of the demo kind should also (as much as possible) be in accordance with where the related entity is defined and where the first appearance of related seed data records are defined. For guidance see the entity reference (per link below)
> Example 1:
>  The ProductStore entity is defined in the entity model for the Product component (the product-entitymodel.xml).
> Thus any new demo record regarding this ProductStore entity should first appear in the ProductDemoData.xml file.
> Example 2:
>  Following record is defined in WorkEffortTypeData.xml
> {code:java}
> <WorkEffortType description="Project" hasTable="N" workEffortTypeId="PROJECT"/>
> {code}
> Thus any first appearance of a demo record for the WorkEffort entity with the defined workEffortTypeId="PROJECT" should appear in the WorkEffortDemoData.xml file
> With the above we minimise the risk of duplication and dependency mismatches



--
This message was sent by Atlassian Jira
(v8.3.4#803005)