You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ol...@apache.org on 2014/07/28 15:14:18 UTC
[1/2] git commit: minor performance improvement from sonar analysis
Repository: maven-scm
Updated Branches:
refs/heads/master e98f33452 -> 8aba9ff62
minor performance improvement from sonar analysis
Project: http://git-wip-us.apache.org/repos/asf/maven-scm/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven-scm/commit/db59b772
Tree: http://git-wip-us.apache.org/repos/asf/maven-scm/tree/db59b772
Diff: http://git-wip-us.apache.org/repos/asf/maven-scm/diff/db59b772
Branch: refs/heads/master
Commit: db59b7721bfb8f91590b64818dfd2354ed13bda1
Parents: e98f334
Author: Olivier Lamy <ol...@apache.org>
Authored: Mon Jul 28 23:12:11 2014 +1000
Committer: Olivier Lamy <ol...@apache.org>
Committed: Mon Jul 28 23:12:11 2014 +1000
----------------------------------------------------------------------
.../src/main/java/org/apache/maven/scm/provider/hg/HgUtils.java | 3 ++-
.../apache/maven/scm/provider/starteam/StarteamScmProvider.java | 2 +-
.../apache/maven/scm/provider/cvslib/AbstractCvsScmProvider.java | 2 +-
.../maven/scm/provider/cvslib/cvsexe/CvsExeScmProvider.java | 2 +-
4 files changed, 5 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/maven-scm/blob/db59b772/maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/HgUtils.java
----------------------------------------------------------------------
diff --git a/maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/HgUtils.java b/maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/HgUtils.java
index 88b37df..40240c5 100644
--- a/maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/HgUtils.java
+++ b/maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/HgUtils.java
@@ -50,6 +50,7 @@ public final class HgUtils
private HgUtils()
{
+ // no op
}
/**
@@ -65,7 +66,7 @@ public final class HgUtils
/** Setup exit codes*/
static
{
- DEFAULT_EXIT_CODES.add( new Integer( 0 ) );
+ DEFAULT_EXIT_CODES.add( Integer.valueOf( 0 ) );
//Diff is different
List<Integer> diffExitCodes = new ArrayList<Integer>( 3 );
http://git-wip-us.apache.org/repos/asf/maven-scm/blob/db59b772/maven-scm-providers/maven-scm-provider-starteam/src/main/java/org/apache/maven/scm/provider/starteam/StarteamScmProvider.java
----------------------------------------------------------------------
diff --git a/maven-scm-providers/maven-scm-provider-starteam/src/main/java/org/apache/maven/scm/provider/starteam/StarteamScmProvider.java b/maven-scm-providers/maven-scm-provider-starteam/src/main/java/org/apache/maven/scm/provider/starteam/StarteamScmProvider.java
index 1628468..b8327bc 100644
--- a/maven-scm-providers/maven-scm-provider-starteam/src/main/java/org/apache/maven/scm/provider/starteam/StarteamScmProvider.java
+++ b/maven-scm-providers/maven-scm-provider-starteam/src/main/java/org/apache/maven/scm/provider/starteam/StarteamScmProvider.java
@@ -114,7 +114,7 @@ public class StarteamScmProvider
{
host = tokens[0];
- port = new Integer( tokens[1] ).intValue();
+ port = Integer.valueOf( tokens[1] ).intValue();
path = tokens[2];
}
http://git-wip-us.apache.org/repos/asf/maven-scm/blob/db59b772/maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvs-commons/src/main/java/org/apache/maven/scm/provider/cvslib/AbstractCvsScmProvider.java
----------------------------------------------------------------------
diff --git a/maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvs-commons/src/main/java/org/apache/maven/scm/provider/cvslib/AbstractCvsScmProvider.java b/maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvs-commons/src/main/java/org/apache/maven/scm/provider/cvslib/AbstractCvsScmProvider.java
index 19ffd77..8411304 100644
--- a/maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvs-commons/src/main/java/org/apache/maven/scm/provider/cvslib/AbstractCvsScmProvider.java
+++ b/maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvs-commons/src/main/java/org/apache/maven/scm/provider/cvslib/AbstractCvsScmProvider.java
@@ -529,7 +529,7 @@ public abstract class AbstractCvsScmProvider
host = passhost.substring( index + 1 );
- port = new Integer( tokens[3] ).intValue();
+ port = Integer.valueOf( tokens[3] ).intValue();
path = tokens[4];
http://git-wip-us.apache.org/repos/asf/maven-scm/blob/db59b772/maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvsexe/src/main/java/org/apache/maven/scm/provider/cvslib/cvsexe/CvsExeScmProvider.java
----------------------------------------------------------------------
diff --git a/maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvsexe/src/main/java/org/apache/maven/scm/provider/cvslib/cvsexe/CvsExeScmProvider.java b/maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvsexe/src/main/java/org/apache/maven/scm/provider/cvslib/cvsexe/CvsExeScmProvider.java
index c999e9f..cc78b0a 100644
--- a/maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvsexe/src/main/java/org/apache/maven/scm/provider/cvslib/cvsexe/CvsExeScmProvider.java
+++ b/maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvsexe/src/main/java/org/apache/maven/scm/provider/cvslib/cvsexe/CvsExeScmProvider.java
@@ -227,7 +227,7 @@ public class CvsExeScmProvider
// getting port
try
{
- port = new Integer( tokens[2] ).intValue();
+ port = Integer.valueOf( tokens[2] ).intValue();
path = tokens[3];
module = tokens[4];
}
[2/2] git commit: close stream
Posted by ol...@apache.org.
close stream
Project: http://git-wip-us.apache.org/repos/asf/maven-scm/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven-scm/commit/8aba9ff6
Tree: http://git-wip-us.apache.org/repos/asf/maven-scm/tree/8aba9ff6
Diff: http://git-wip-us.apache.org/repos/asf/maven-scm/diff/8aba9ff6
Branch: refs/heads/master
Commit: 8aba9ff6243a3a7c025834b042cefb84cc9b6908
Parents: db59b77
Author: Olivier Lamy <ol...@apache.org>
Authored: Mon Jul 28 23:13:42 2014 +1000
Committer: Olivier Lamy <ol...@apache.org>
Committed: Mon Jul 28 23:13:42 2014 +1000
----------------------------------------------------------------------
.../tck/command/checkin/CheckInCommandTckTest.java | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/maven-scm/blob/8aba9ff6/maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/checkin/CheckInCommandTckTest.java
----------------------------------------------------------------------
diff --git a/maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/checkin/CheckInCommandTckTest.java b/maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/checkin/CheckInCommandTckTest.java
index 55069ee..f120926 100644
--- a/maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/checkin/CheckInCommandTckTest.java
+++ b/maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/checkin/CheckInCommandTckTest.java
@@ -39,7 +39,6 @@ import java.util.Map;
* This test tests the check out command.
*
* @author <a href="mailto:brett@apache.org">Brett Porter</a>
- *
*/
public abstract class CheckInCommandTckTest
extends ScmTckTestCase
@@ -231,10 +230,17 @@ public abstract class CheckInCommandTckTest
private void changeReadmeTxt( File readmeTxt )
throws Exception
{
- FileWriter output = new FileWriter( readmeTxt );
+ FileWriter output = null;
- output.write( "changed file" );
+ try
+ {
+ output = new FileWriter( readmeTxt );
- output.close();
+ output.write( "changed file" );
+ }
+ finally
+ {
+ IOUtil.close( output );
+ }
}
}