You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "aliehsaeedii (via GitHub)" <gi...@apache.org> on 2023/12/07 11:56:49 UTC
[PR] Update upgrade-guide.html for KIP-960 and KIP-968 [kafka]
aliehsaeedii opened a new pull request, #14958:
URL: https://github.com/apache/kafka/pull/14958
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update upgrade-guide.html for KIP-960 and KIP-968 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #14958:
URL: https://github.com/apache/kafka/pull/14958#discussion_r1419754832
##########
docs/streams/upgrade-guide.html:
##########
@@ -134,6 +134,24 @@ <h3 class="anchor-heading"><a id="streams_notable_changes" class="anchor-link"><
</p>
<h3><a id="streams_api_changes_370" href="#streams_api_changes_370">Streams API changes in 3.7.0</a></h3>
+ <p>
+ IQv2 supports <code>MultiVersionedKeyQuery</code> (introduced in <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-968%3A+Support+single-key_multi-timestamp+interactive+queries+%28IQv2%29+for+versioned+state+stores">KIP-968</a>)
Review Comment:
`IQv2 adds support for retrieving`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update upgrade-guide.html for KIP-960 and KIP-968 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #14958:
URL: https://github.com/apache/kafka/pull/14958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update upgrade-guide.html for KIP-960 and KIP-968 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #14958:
URL: https://github.com/apache/kafka/pull/14958#discussion_r1419757044
##########
docs/streams/upgrade-guide.html:
##########
@@ -134,6 +134,24 @@ <h3 class="anchor-heading"><a id="streams_notable_changes" class="anchor-link"><
</p>
<h3><a id="streams_api_changes_370" href="#streams_api_changes_370">Streams API changes in 3.7.0</a></h3>
+ <p>
+ IQv2 supports <code>MultiVersionedKeyQuery</code> (introduced in <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-968%3A+Support+single-key_multi-timestamp+interactive+queries+%28IQv2%29+for+versioned+state+stores">KIP-968</a>)
Review Comment:
The paragraph should mentioned that this new query type is for versioned state-stores, and thus add IQ support for the new versioned stores.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update upgrade-guide.html for KIP-960 and KIP-968 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #14958:
URL: https://github.com/apache/kafka/pull/14958#discussion_r1419755463
##########
docs/streams/upgrade-guide.html:
##########
@@ -134,6 +134,24 @@ <h3 class="anchor-heading"><a id="streams_notable_changes" class="anchor-link"><
</p>
<h3><a id="streams_api_changes_370" href="#streams_api_changes_370">Streams API changes in 3.7.0</a></h3>
+ <p>
+ IQv2 supports <code>MultiVersionedKeyQuery</code> (introduced in <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-968%3A+Support+single-key_multi-timestamp+interactive+queries+%28IQv2%29+for+versioned+state+stores">KIP-968</a>)
+ that allows retrieving a set of records with the same specified key and different timestamps within a specified time range.
Review Comment:
`with the same specified` -> `for a given key` ?
`and a specified time range.` (Maybe highlight that it's basically a historic query?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update upgrade-guide.html for KIP-960 and KIP-968 [kafka]
Posted by "aliehsaeedii (via GitHub)" <gi...@apache.org>.
aliehsaeedii commented on PR #14958:
URL: https://github.com/apache/kafka/pull/14958#issuecomment-1847136781
> Thanks. A few suggestions.
>
> Leave it up to you. Also ok to keep more details as this PR does currently.
Thanks. I followed your suggestions ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update upgrade-guide.html for KIP-960 and KIP-968 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #14958:
URL: https://github.com/apache/kafka/pull/14958#discussion_r1419756273
##########
docs/streams/upgrade-guide.html:
##########
@@ -134,6 +134,24 @@ <h3 class="anchor-heading"><a id="streams_notable_changes" class="anchor-link"><
</p>
<h3><a id="streams_api_changes_370" href="#streams_api_changes_370">Streams API changes in 3.7.0</a></h3>
+ <p>
+ IQv2 supports <code>MultiVersionedKeyQuery</code> (introduced in <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-968%3A+Support+single-key_multi-timestamp+interactive+queries+%28IQv2%29+for+versioned+state+stores">KIP-968</a>)
+ that allows retrieving a set of records with the same specified key and different timestamps within a specified time range.
+ Users have to use <code>fromTime(Instant)</code> and/or <code>toTime(Instant)</code> to specify a half or a complete time range.
+ In the case of specifying no starting point and ending point for the time range, the query will return all the existing records associated with the specified key.
Review Comment:
Think we can omit this sentence? Too much detail?
We might want to update the "main IQ" docs though, additionally? IIRC, IQv2 is very sparsely (or maybe even not at all) explained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update upgrade-guide.html for KIP-960 and KIP-968 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #14958:
URL: https://github.com/apache/kafka/pull/14958#discussion_r1419755463
##########
docs/streams/upgrade-guide.html:
##########
@@ -134,6 +134,24 @@ <h3 class="anchor-heading"><a id="streams_notable_changes" class="anchor-link"><
</p>
<h3><a id="streams_api_changes_370" href="#streams_api_changes_370">Streams API changes in 3.7.0</a></h3>
+ <p>
+ IQv2 supports <code>MultiVersionedKeyQuery</code> (introduced in <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-968%3A+Support+single-key_multi-timestamp+interactive+queries+%28IQv2%29+for+versioned+state+stores">KIP-968</a>)
+ that allows retrieving a set of records with the same specified key and different timestamps within a specified time range.
Review Comment:
`with the same specified` -> `for a given key` ?
`and a specified time range.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update upgrade-guide.html for KIP-960 and KIP-968 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #14958:
URL: https://github.com/apache/kafka/pull/14958#discussion_r1419756415
##########
docs/streams/upgrade-guide.html:
##########
@@ -134,6 +134,24 @@ <h3 class="anchor-heading"><a id="streams_notable_changes" class="anchor-link"><
</p>
<h3><a id="streams_api_changes_370" href="#streams_api_changes_370">Streams API changes in 3.7.0</a></h3>
+ <p>
+ IQv2 supports <code>MultiVersionedKeyQuery</code> (introduced in <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-968%3A+Support+single-key_multi-timestamp+interactive+queries+%28IQv2%29+for+versioned+state+stores">KIP-968</a>)
+ that allows retrieving a set of records with the same specified key and different timestamps within a specified time range.
+ Users have to use <code>fromTime(Instant)</code> and/or <code>toTime(Instant)</code> to specify a half or a complete time range.
+ In the case of specifying no starting point and ending point for the time range, the query will return all the existing records associated with the specified key.
+ No ordering is guaranteed for the results, but the results can be sorted by timestamp in ascending or descending order by calling the corresponding defined methods
+ <code>withAscendingTimestamps()</code> or <code>withDescendingTimestamps()</code>, respectively.
Review Comment:
Similar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update upgrade-guide.html for KIP-960 and KIP-968 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #14958:
URL: https://github.com/apache/kafka/pull/14958#issuecomment-1846252181
PR need to be rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org