You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/12/07 19:01:14 UTC
[GitHub] [systemds] OlgaOvcharenko opened a new pull request #1477: [WIP][SYSTEMDS-3241] Federated quantile
OlgaOvcharenko opened a new pull request #1477:
URL: https://github.com/apache/systemds/pull/1477
This PR adds federated quantile for row federated matrices.
1. qsort creates a copy of the input MatrixObject without sorting it.
2. qpick recursively creates histogram between min and max of the MatrixObject.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1477: [SYSTEMDS-3241] Federated quantile
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1477:
URL: https://github.com/apache/systemds/pull/1477#issuecomment-1058517671
LGTM - thanks for the patch @OlgaOvcharenko, this is a great extension and very useful for plenty of pre-processing primitives. During the merge, I only made a few minor tweaks in the qpick instruction, and re-enabled the tests for column-partitioned data again (which were commented, probably for local testing).
Once you get a chance, could you please then follow up and improve the performance of the histogram construction (e.g., the `GetValuesInRange` UDF) to use an array of pre-materialized bin boundaries and binary search similar to transformencode-binning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] asfgit closed pull request #1477: [SYSTEMDS-3241] Federated quantile
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1477:
URL: https://github.com/apache/systemds/pull/1477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org