[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4011: Added a percent threshold to consider startup of services

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4011: Added a percent threshold to consider startup of services
URL: https://github.com/apache/incubator-pinot/pull/4011#discussion_r268760987
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java
 ##########
 @@ -243,11 +278,18 @@ public synchronized Status getServiceStatus() {
         }
 
         // Resource is done starting up, remove it from the set
-        iterator.remove();
 
 Review comment:
   Nope. the return should be as it is, because we want to stop when we reach a bad resource. We already check the threshold at the top of the loop, so if we are inside the loop the threshold is not met yet. We check only one resource each time in the loop

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org