You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/17 12:32:49 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2233: support array with scalar arithmetic operation for decimal data type

alamb commented on code in PR #2233:
URL: https://github.com/apache/arrow-datafusion/pull/2233#discussion_r851749656


##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -280,25 +280,64 @@ where
         .collect()
 }
 
+fn arith_decimal_scalar<F>(

Review Comment:
   It would be great to move some / all of this decimal manipulation into the arrow-rs crate at some point



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org