You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/01/29 11:39:55 UTC
[GitHub] [maven-integration-testing] mthmulders opened a new pull request
#54: [MNG-4660] Add integration test to show that --resume-from works
mthmulders opened a new pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54
Will offer this one for merging once the bug has indeed been fixed, and the `// TODO` regarding the version range has been resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull
request #54: [MNG-4660] Add integration test to show that --resume-from works
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r373367869
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
##########
@@ -231,6 +231,7 @@ public static Test suite()
suite.addTestSuite( MavenITmng4679SnapshotUpdateInPluginTest.class );
suite.addTestSuite( MavenITmng4677DisabledPluginConfigInheritanceTest.class );
suite.addTestSuite( MavenITmng4666CoreRealmImportTest.class );
+ suite.addTestSuite( MavenITmng4660ResumeFromTest.class );
Review comment:
In general this is in order of implementation, not in order of reporting (also helps with fast feedback)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] mthmulders commented on a change in
pull request #54: [MNG-4660] Add integration test to show that
--resume-from works
Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r382919774
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6090CIFriendlyTest.java
##########
@@ -61,7 +60,7 @@ public void testitShouldResolveTheDependencies()
verifier.addCliOption( "-Drevision=1.2" );
verifier.setLogFileName( "install-log.txt" );
- verifier.executeGoals( Arrays.asList( "clean", "install" ) );
Review comment:
It was an intended change, we figured that `clean install` was no longer needed. But I guess it'll still work 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] mthmulders commented on a change in
pull request #54: [MNG-4660] Add integration test to show that
--resume-from works
Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r373919225
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
##########
@@ -231,6 +231,7 @@ public static Test suite()
suite.addTestSuite( MavenITmng4679SnapshotUpdateInPluginTest.class );
suite.addTestSuite( MavenITmng4677DisabledPluginConfigInheritanceTest.class );
suite.addTestSuite( MavenITmng4666CoreRealmImportTest.class );
+ suite.addTestSuite( MavenITmng4660ResumeFromTest.class );
Review comment:
[Line 723](https://github.com/apache/maven-integration-testing/blob/e8f24ba23d9a8d97a2e1e8c9920213ffb6ebe772/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java#L723) suggests something else...:
> Add tests in reverse alpha order above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] mthmulders commented on a change in
pull request #54: [MNG-4660] Add integration test to show that
--resume-from works
Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r375237112
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
##########
@@ -231,6 +231,7 @@ public static Test suite()
suite.addTestSuite( MavenITmng4679SnapshotUpdateInPluginTest.class );
suite.addTestSuite( MavenITmng4677DisabledPluginConfigInheritanceTest.class );
suite.addTestSuite( MavenITmng4666CoreRealmImportTest.class );
+ suite.addTestSuite( MavenITmng4660ResumeFromTest.class );
Review comment:
OK, I'll await the outcome of that and then update the place of this new test in the suite.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] mthmulders commented on a change in
pull request #54: [MNG-4660] Add integration test to show that
--resume-from works
Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r376241502
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4660ResumeFromTest.java
##########
@@ -0,0 +1,74 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+
+/**
+ * This is a test case for <a href="https://issues.apache.org/jira/browse/MNG-4660">MNG-4660</a>.
+ *
+ * @author Maarten Mulders
+ * @author Martin Kanters
+ */
+public class MavenITmng4660ResumeFromTest extends AbstractMavenIntegrationTestCase {
+ public MavenITmng4660ResumeFromTest()
+ {
+ // TODO Update version range once bug has been fixed!
+ super( "[3.6.3,)" );
+ }
+
+ /**
+ * Test that the --resume-from flag resolves dependencies inside the same Maven project
+ * without having them installed first.
+ */
+ public void testIt() throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-4660-resume-from" );
+
+ final Verifier verifier1 = newVerifier( testDir.getAbsolutePath() );
+ verifier1.deleteDirectory( "target" );
+ verifier1.deleteArtifacts( "org.apache.maven.its.mng4660" );
+
+ try
+ {
+ verifier1.executeGoal("verify");
+ fail( "Expected this invocation to fail" ); // See TestCase.java
+ }
+ catch ( final VerificationException ve )
+ {
+ verifier1.verifyTextInLog( "Deliberately fail test case" );
+ }
+ finally
+ {
+ verifier1.resetStreams();
+ }
+
+ final Verifier verifier2 = newVerifier( testDir.getAbsolutePath() );
+ verifier2.setAutoclean( false );
+ verifier2.addCliOption( "--resume-from" );
+ verifier2.addCliOption( ":module-b" );
+ verifier2.executeGoal( "compile" ); // to prevent the unit test from failing (again)
Review comment:
We do option 2, but instead of recompiling module-a, we want to reuse the outcome of the previous build, which did include module-a. That's why we have `--resume-from :module-b` and _autoclean_ set to off. The test that resides in module-b would fail again and that's why we went for `compile`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull
request #54: [MNG-4660] Add integration test to show that --resume-from works
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r374871274
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
##########
@@ -231,6 +231,7 @@ public static Test suite()
suite.addTestSuite( MavenITmng4679SnapshotUpdateInPluginTest.class );
suite.addTestSuite( MavenITmng4677DisabledPluginConfigInheritanceTest.class );
suite.addTestSuite( MavenITmng4666CoreRealmImportTest.class );
+ suite.addTestSuite( MavenITmng4660ResumeFromTest.class );
Review comment:
I see, and https://github.com/apache/maven-integration-testing/blob/e8f24ba23d9a8d97a2e1e8c9920213ffb6ebe772/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java#L88-L93 seems contradictionary. This text must be from the period we didn't start with MNG-nnn yet. However, the intention is right: newer tests are more likely to fail, so start with those.
I'll rewrite it...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull
request #54: [MNG-4660] Add integration test to show that --resume-from works
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r399149558
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4660OutdatedPackagedArtifact.java
##########
@@ -0,0 +1,91 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.util.ResourceExtractor;
+import org.apache.maven.shared.utils.io.FileUtils;
+
+import java.io.File;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+
+/**
+ * This is a test case for a new check introduced with <a href="https://issues.apache.org/jira/browse/MNG-4660">MNG-4660</a>.
+ * That check verifies if a packaged artifact within the Reactor is up-to-date with the outputDirectory of the same project.
+ *
+ * @author Maarten Mulders
+ * @author Martin Kanters
+ */
+public class MavenITmng4660OutdatedPackagedArtifact extends AbstractMavenIntegrationTestCase {
+ public MavenITmng4660OutdatedPackagedArtifact()
+ {
+ super( "[3.7.0,)" );
+ }
+
+ /**
+ * Test that Maven logs a warning when a packaged artifact is found that is older than the outputDirectory of the
+ * same artifact.
+ */
+ public void testShouldWarnWhenPackagedArtifactIsOutdated() throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-4660-outdated-packaged-artifact" );
+
+ // 1. Package the whole project
+ final Verifier verifier1 = newVerifier( testDir.getAbsolutePath() );
+ verifier1.deleteDirectory( "target" );
+ verifier1.deleteArtifacts( "org.apache.maven.its.mng4660" );
+
+ verifier1.executeGoal( "package" );
+
+ verifier1.verifyErrorFreeLog();
+ verifier1.resetStreams();
+
+
+ // 2. Create a properties file with some content and compile only that module (module A).
+ final Verifier verifier2 = newVerifier( testDir.getAbsolutePath() );
+
+ final Path resourcesDirectory = Files.createDirectories( Paths.get( testDir.toString(), "module-a", "src", "main", "resources" ) );
+ System.err.println( "Created directory " + resourcesDirectory.toAbsolutePath().toString() );
+ final Path fileToWrite = resourcesDirectory.resolve( "example.properties" );
+ FileUtils.fileWrite( fileToWrite.toString(), "x=42" );
+ System.err.println( "Wrote file " + fileToWrite.toAbsolutePath().toString() );
Review comment:
Same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] MartinKanters commented on a change in
pull request #54: [MNG-4660] Add integration test to show that
--resume-from works
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r382918887
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6090CIFriendlyTest.java
##########
@@ -61,7 +60,7 @@ public void testitShouldResolveTheDependencies()
verifier.addCliOption( "-Drevision=1.2" );
verifier.setLogFileName( "install-log.txt" );
- verifier.executeGoals( Arrays.asList( "clean", "install" ) );
Review comment:
Right, I'm not sure if this was an intended change. I've reverted it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull
request #54: [MNG-4660] Add integration test to show that --resume-from works
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r382906447
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6090CIFriendlyTest.java
##########
@@ -61,7 +60,7 @@ public void testitShouldResolveTheDependencies()
verifier.addCliOption( "-Drevision=1.2" );
verifier.setLogFileName( "install-log.txt" );
- verifier.executeGoals( Arrays.asList( "clean", "install" ) );
Review comment:
Please don't change other integration tests, only the version-range if the behavior changes (or add code)
I'm pretty sure you want to test the `install` phase when working with CI-friendly versions, to ensure that still works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] mthmulders commented on a change in
pull request #54: [MNG-4660] Add integration test to show that
--resume-from works
Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r399169899
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6090CIFriendlyTest.java
##########
@@ -19,7 +19,6 @@
* under the License.
*/
-import org.apache.maven.it.Verifier;
Review comment:
Don't be scared, it's been reverted already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull
request #54: [MNG-4660] Add integration test to show that --resume-from works
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r399168211
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6090CIFriendlyTest.java
##########
@@ -19,7 +19,6 @@
* under the License.
*/
-import org.apache.maven.it.Verifier;
Review comment:
It will look very weird if we go through the commit logs and see the list of files touched by this commit. It scares me if I see MNG6090 between MNG4660
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] mthmulders commented on a change in
pull request #54: [MNG-4660] Add integration test to show that
--resume-from works
Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r399155368
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4660ResumeFromTest.java
##########
@@ -0,0 +1,111 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+
+/**
+ * This is a test case for <a href="https://issues.apache.org/jira/browse/MNG-4660">MNG-4660</a>.
+ *
+ * @author Maarten Mulders
+ * @author Martin Kanters
+ */
+public class MavenITmng4660ResumeFromTest extends AbstractMavenIntegrationTestCase {
+ public MavenITmng4660ResumeFromTest()
+ {
+ super( "[3.7.0,)" );
+ }
+
+ /**
+ * Test that the --resume-from flag resolves dependencies inside the same Maven project
+ * without having them installed first.
+ * This test case uses the target/classes folder of module-a.
+ */
+ public void testShouldResolveUnpackagedArtifactFromEarlierBuild() throws Exception
Review comment:
Agreed, updated method name as well as Javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] MartinKanters commented on a change in
pull request #54: [MNG-4660] Add integration test to show that
--resume-from works
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r382918941
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4660ResumeFromTest.java
##########
@@ -0,0 +1,73 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+
+/**
+ * This is a test case for <a href="https://issues.apache.org/jira/browse/MNG-4660">MNG-4660</a>.
+ *
+ * @author Maarten Mulders
+ * @author Martin Kanters
+ */
+public class MavenITmng4660ResumeFromTest extends AbstractMavenIntegrationTestCase {
+ public MavenITmng4660ResumeFromTest()
+ {
+ super( "[3.7.0-SNAPSHOT,)" );
Review comment:
Interesting! Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull
request #54: [MNG-4660] Add integration test to show that --resume-from works
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r373371441
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4660ResumeFromTest.java
##########
@@ -0,0 +1,74 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+
+/**
+ * This is a test case for <a href="https://issues.apache.org/jira/browse/MNG-4660">MNG-4660</a>.
+ *
+ * @author Maarten Mulders
+ * @author Martin Kanters
+ */
+public class MavenITmng4660ResumeFromTest extends AbstractMavenIntegrationTestCase {
+ public MavenITmng4660ResumeFromTest()
+ {
+ // TODO Update version range once bug has been fixed!
+ super( "[3.6.3,)" );
+ }
+
+ /**
+ * Test that the --resume-from flag resolves dependencies inside the same Maven project
+ * without having them installed first.
+ */
+ public void testIt() throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-4660-resume-from" );
+
+ final Verifier verifier1 = newVerifier( testDir.getAbsolutePath() );
+ verifier1.deleteDirectory( "target" );
+ verifier1.deleteArtifacts( "org.apache.maven.its.mng4660" );
+
+ try
+ {
+ verifier1.executeGoal("verify");
+ fail( "Expected this invocation to fail" ); // See TestCase.java
+ }
+ catch ( final VerificationException ve )
+ {
+ verifier1.verifyTextInLog( "Deliberately fail test case" );
+ }
+ finally
+ {
+ verifier1.resetStreams();
+ }
+
+ final Verifier verifier2 = newVerifier( testDir.getAbsolutePath() );
+ verifier2.setAutoclean( false );
+ verifier2.addCliOption( "--resume-from" );
+ verifier2.addCliOption( ":module-b" );
+ verifier2.executeGoal( "compile" ); // to prevent the unit test from failing (again)
Review comment:
This looks like a mixup of 2 separate issues:
1. you want to continue and reuse the artifacts that have already been build. In that case the goal should be `verify`.
2. you want to compile module-b, but since Maven hasn't attached its artifacts to the reactor, you need to recompile module-a too. In that case I would add `verifier2.addCliOption( "--also-make" );`
Both are interesting and don't work right now. 1 is harder (and matches the description of the issue), 2 should be reasonably easier and already a huge improvement, but requires a separate issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] MartinKanters commented on a change in
pull request #54: [MNG-4660] Add integration test to show that
--resume-from works
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r389519663
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
##########
@@ -231,6 +231,7 @@ public static Test suite()
suite.addTestSuite( MavenITmng4679SnapshotUpdateInPluginTest.class );
suite.addTestSuite( MavenITmng4677DisabledPluginConfigInheritanceTest.class );
suite.addTestSuite( MavenITmng4666CoreRealmImportTest.class );
+ suite.addTestSuite( MavenITmng4660ResumeFromTest.class );
Review comment:
I've put the test at the top of the list. Do you want us to change the javadoc (pointed out by Maarten above) or do you want to do that separately?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull
request #54: [MNG-4660] Add integration test to show that --resume-from works
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r399151680
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4660ResumeFromTest.java
##########
@@ -0,0 +1,111 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+
+/**
+ * This is a test case for <a href="https://issues.apache.org/jira/browse/MNG-4660">MNG-4660</a>.
+ *
+ * @author Maarten Mulders
+ * @author Martin Kanters
+ */
+public class MavenITmng4660ResumeFromTest extends AbstractMavenIntegrationTestCase {
+ public MavenITmng4660ResumeFromTest()
+ {
+ super( "[3.7.0,)" );
+ }
+
+ /**
+ * Test that the --resume-from flag resolves dependencies inside the same Maven project
+ * without having them installed first.
+ * This test case uses the target/classes folder of module-a.
+ */
+ public void testShouldResolveUnpackagedArtifactFromEarlierBuild() throws Exception
Review comment:
method name is a bit confusing. 'Unpackaged' might suggest the artifact is unpackaged in the process. Here you want to use the outputDirectory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] mthmulders commented on a change in
pull request #54: [MNG-4660] Add integration test to show that
--resume-from works
Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r399154201
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4660OutdatedPackagedArtifact.java
##########
@@ -0,0 +1,91 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.util.ResourceExtractor;
+import org.apache.maven.shared.utils.io.FileUtils;
+
+import java.io.File;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+
+/**
+ * This is a test case for a new check introduced with <a href="https://issues.apache.org/jira/browse/MNG-4660">MNG-4660</a>.
+ * That check verifies if a packaged artifact within the Reactor is up-to-date with the outputDirectory of the same project.
+ *
+ * @author Maarten Mulders
+ * @author Martin Kanters
+ */
+public class MavenITmng4660OutdatedPackagedArtifact extends AbstractMavenIntegrationTestCase {
+ public MavenITmng4660OutdatedPackagedArtifact()
+ {
+ super( "[3.7.0,)" );
+ }
+
+ /**
+ * Test that Maven logs a warning when a packaged artifact is found that is older than the outputDirectory of the
+ * same artifact.
+ */
+ public void testShouldWarnWhenPackagedArtifactIsOutdated() throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-4660-outdated-packaged-artifact" );
+
+ // 1. Package the whole project
+ final Verifier verifier1 = newVerifier( testDir.getAbsolutePath() );
+ verifier1.deleteDirectory( "target" );
+ verifier1.deleteArtifacts( "org.apache.maven.its.mng4660" );
+
+ verifier1.executeGoal( "package" );
+
+ verifier1.verifyErrorFreeLog();
+ verifier1.resetStreams();
+
+
+ // 2. Create a properties file with some content and compile only that module (module A).
+ final Verifier verifier2 = newVerifier( testDir.getAbsolutePath() );
+
+ final Path resourcesDirectory = Files.createDirectories( Paths.get( testDir.toString(), "module-a", "src", "main", "resources" ) );
+ System.err.println( "Created directory " + resourcesDirectory.toAbsolutePath().toString() );
+ final Path fileToWrite = resourcesDirectory.resolve( "example.properties" );
+ FileUtils.fileWrite( fileToWrite.toString(), "x=42" );
+ System.err.println( "Wrote file " + fileToWrite.toAbsolutePath().toString() );
Review comment:
Oops, removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] mthmulders commented on a change in
pull request #54: [MNG-4660] Add integration test to show that
--resume-from works
Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r399156051
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6090CIFriendlyTest.java
##########
@@ -19,7 +19,6 @@
* under the License.
*/
-import org.apache.maven.it.Verifier;
Review comment:
True. We were investigating that test case and probably the IDE thought it'd be good to cleanup unused imports. Prefer to have it reverted? I think it won't hurt either....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull
request #54: [MNG-4660] Add integration test to show that --resume-from works
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r399154213
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6090CIFriendlyTest.java
##########
@@ -19,7 +19,6 @@
* under the License.
*/
-import org.apache.maven.it.Verifier;
Review comment:
unrelated change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull
request #54: [MNG-4660] Add integration test to show that --resume-from works
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r399149432
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4660OutdatedPackagedArtifact.java
##########
@@ -0,0 +1,91 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.util.ResourceExtractor;
+import org.apache.maven.shared.utils.io.FileUtils;
+
+import java.io.File;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+
+/**
+ * This is a test case for a new check introduced with <a href="https://issues.apache.org/jira/browse/MNG-4660">MNG-4660</a>.
+ * That check verifies if a packaged artifact within the Reactor is up-to-date with the outputDirectory of the same project.
+ *
+ * @author Maarten Mulders
+ * @author Martin Kanters
+ */
+public class MavenITmng4660OutdatedPackagedArtifact extends AbstractMavenIntegrationTestCase {
+ public MavenITmng4660OutdatedPackagedArtifact()
+ {
+ super( "[3.7.0,)" );
+ }
+
+ /**
+ * Test that Maven logs a warning when a packaged artifact is found that is older than the outputDirectory of the
+ * same artifact.
+ */
+ public void testShouldWarnWhenPackagedArtifactIsOutdated() throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-4660-outdated-packaged-artifact" );
+
+ // 1. Package the whole project
+ final Verifier verifier1 = newVerifier( testDir.getAbsolutePath() );
+ verifier1.deleteDirectory( "target" );
+ verifier1.deleteArtifacts( "org.apache.maven.its.mng4660" );
+
+ verifier1.executeGoal( "package" );
+
+ verifier1.verifyErrorFreeLog();
+ verifier1.resetStreams();
+
+
+ // 2. Create a properties file with some content and compile only that module (module A).
+ final Verifier verifier2 = newVerifier( testDir.getAbsolutePath() );
+
+ final Path resourcesDirectory = Files.createDirectories( Paths.get( testDir.toString(), "module-a", "src", "main", "resources" ) );
+ System.err.println( "Created directory " + resourcesDirectory.toAbsolutePath().toString() );
Review comment:
System.x.println don't belong in tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull
request #54: [MNG-4660] Add integration test to show that --resume-from works
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r373372730
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4660ResumeFromTest.java
##########
@@ -0,0 +1,74 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+
+/**
+ * This is a test case for <a href="https://issues.apache.org/jira/browse/MNG-4660">MNG-4660</a>.
+ *
+ * @author Maarten Mulders
+ * @author Martin Kanters
+ */
+public class MavenITmng4660ResumeFromTest extends AbstractMavenIntegrationTestCase {
+ public MavenITmng4660ResumeFromTest()
+ {
+ // TODO Update version range once bug has been fixed!
+ super( "[3.6.3,)" );
+ }
+
+ /**
+ * Test that the --resume-from flag resolves dependencies inside the same Maven project
+ * without having them installed first.
+ */
+ public void testIt() throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-4660-resume-from" );
+
+ final Verifier verifier1 = newVerifier( testDir.getAbsolutePath() );
+ verifier1.deleteDirectory( "target" );
+ verifier1.deleteArtifacts( "org.apache.maven.its.mng4660" );
+
+ try
+ {
+ verifier1.executeGoal("verify");
+ fail( "Expected this invocation to fail" ); // See TestCase.java
+ }
+ catch ( final VerificationException ve )
+ {
+ verifier1.verifyTextInLog( "Deliberately fail test case" );
+ }
+ finally
+ {
+ verifier1.resetStreams();
+ }
+
+ final Verifier verifier2 = newVerifier( testDir.getAbsolutePath() );
+ verifier2.setAutoclean( false );
+ verifier2.addCliOption( "--resume-from" );
+ verifier2.addCliOption( ":module-b" );
+ verifier2.executeGoal( "compile" ); // to prevent the unit test from failing (again)
Review comment:
BTW I do like this usecase: ignore the testresult of an early module for now, continue with its artifact to see the result for the rest of the project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull
request #54: [MNG-4660] Add integration test to show that --resume-from works
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r399201617
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
##########
@@ -231,6 +231,7 @@ public static Test suite()
suite.addTestSuite( MavenITmng4679SnapshotUpdateInPluginTest.class );
suite.addTestSuite( MavenITmng4677DisabledPluginConfigInheritanceTest.class );
suite.addTestSuite( MavenITmng4666CoreRealmImportTest.class );
+ suite.addTestSuite( MavenITmng4660ResumeFromTest.class );
Review comment:
I will update the javadoc. I've found several places that require an update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] mthmulders commented on a change in
pull request #54: [MNG-4660] Add integration test to show that
--resume-from works
Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r399154143
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4660OutdatedPackagedArtifact.java
##########
@@ -0,0 +1,91 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.util.ResourceExtractor;
+import org.apache.maven.shared.utils.io.FileUtils;
+
+import java.io.File;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+
+/**
+ * This is a test case for a new check introduced with <a href="https://issues.apache.org/jira/browse/MNG-4660">MNG-4660</a>.
+ * That check verifies if a packaged artifact within the Reactor is up-to-date with the outputDirectory of the same project.
+ *
+ * @author Maarten Mulders
+ * @author Martin Kanters
+ */
+public class MavenITmng4660OutdatedPackagedArtifact extends AbstractMavenIntegrationTestCase {
+ public MavenITmng4660OutdatedPackagedArtifact()
+ {
+ super( "[3.7.0,)" );
+ }
+
+ /**
+ * Test that Maven logs a warning when a packaged artifact is found that is older than the outputDirectory of the
+ * same artifact.
+ */
+ public void testShouldWarnWhenPackagedArtifactIsOutdated() throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-4660-outdated-packaged-artifact" );
+
+ // 1. Package the whole project
+ final Verifier verifier1 = newVerifier( testDir.getAbsolutePath() );
+ verifier1.deleteDirectory( "target" );
+ verifier1.deleteArtifacts( "org.apache.maven.its.mng4660" );
+
+ verifier1.executeGoal( "package" );
+
+ verifier1.verifyErrorFreeLog();
+ verifier1.resetStreams();
+
+
+ // 2. Create a properties file with some content and compile only that module (module A).
+ final Verifier verifier2 = newVerifier( testDir.getAbsolutePath() );
+
+ final Path resourcesDirectory = Files.createDirectories( Paths.get( testDir.toString(), "module-a", "src", "main", "resources" ) );
+ System.err.println( "Created directory " + resourcesDirectory.toAbsolutePath().toString() );
Review comment:
Oops, removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull
request #54: [MNG-4660] Add integration test to show that --resume-from works
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54#discussion_r382906246
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4660ResumeFromTest.java
##########
@@ -0,0 +1,73 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+
+/**
+ * This is a test case for <a href="https://issues.apache.org/jira/browse/MNG-4660">MNG-4660</a>.
+ *
+ * @author Maarten Mulders
+ * @author Martin Kanters
+ */
+public class MavenITmng4660ResumeFromTest extends AbstractMavenIntegrationTestCase {
+ public MavenITmng4660ResumeFromTest()
+ {
+ super( "[3.7.0-SNAPSHOT,)" );
Review comment:
This should be 3.7.0, the `AbstractMavenIntegrationTestCase` understands that you need to test this a SNAPSHOT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] rfscholte merged pull request #54:
[MNG-4660] Add integration test to show that --resume-from works
Posted by GitBox <gi...@apache.org>.
rfscholte merged pull request #54: [MNG-4660] Add integration test to show that --resume-from works
URL: https://github.com/apache/maven-integration-testing/pull/54
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services