You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/10/30 17:04:57 UTC

[GitHub] amansinha100 commented on a change in pull request #1514: DRILL-6798: Planner changes to support semi-join.

amansinha100 commented on a change in pull request #1514: DRILL-6798: Planner changes to support semi-join.
URL: https://github.com/apache/drill/pull/1514#discussion_r229376072
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillJoinRelBase.java
 ##########
 @@ -45,7 +46,7 @@
 /**
  * Base class for logical and physical Joins implemented in Drill.
  */
-public abstract class DrillJoinRelBase extends Join implements DrillRelNode {
+public abstract class DrillJoinRelBase extends Join implements DrillRelNode, DrillJoin {
 
 Review comment:
   Since `DrillJoin` already extends `DrillRelNode`,  you can remove `DrillRelNode` from here.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services