You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/20 17:41:20 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31262: [SPARK-34180][SQL] Fix the regression brought by SPARK-33888 for PostgresDialect

dongjoon-hyun commented on a change in pull request #31262:
URL: https://github.com/apache/spark/pull/31262#discussion_r561153148



##########
File path: project/MimaExcludes.scala
##########
@@ -1747,6 +1747,17 @@ object MimaExcludes {
       ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("org.apache.spark.ml.param.shared.HasLoss.org$apache$spark$ml$param$shared$HasLoss$_setter_$loss_="),
       ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("org.apache.spark.ml.param.shared.HasLoss.getLoss"),
       ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("org.apache.spark.ml.param.shared.HasLoss.loss")
+    ) ++ Seq(
+      ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.jdbc.DerbyDialect.getCatalystType"),
+      ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.jdbc.TeradataDialect.getCatalystType"),
+      ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.jdbc.OracleDialect.getCatalystType"),
+      ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.jdbc.PostgresDialect.getCatalystType"),
+      ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.jdbc.DB2Dialect.getCatalystType"),
+      ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.jdbc.MySQLDialect.getCatalystType"),
+      ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.jdbc.MsSqlServerDialect.getCatalystType"),
+      ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.jdbc.JdbcDialect.getCatalystType"),
+      ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.jdbc.NoopDialect.getCatalystType"),
+      ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.jdbc.Dialect.getCatalystType")

Review comment:
       Please add JIRA ID there at the beginning of this block. BTW, why do we need to add this `2.0.x` exclusion rule?
   ```
     // Exclude rules for 2.0.x
     lazy val v20excludes = {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org