[jira] [Commented] (ACCUMULO-1008) Lift gen-{cpp,java,py,rb} from proxy's build.dir

["Josh Elser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568451#comment-13568451 ] 

Josh Elser commented on ACCUMULO-1008:
--------------------------------------

I fixed up the tarball to lift the gen-* stuff out of proxy/target and put it in proxy/thrift.

I also realized that the reactor was building proxy after assemble, so if you had a clean workspace, you wouldn't get anything but the java files for the proxy in your tarball.

I did not address the blanket inclusion of **/*.py which causes some extra cruft to show up (e.g. core/target, trace/target, proxy/target etc)

I'm not sure about the deb or the rpm though as I'm not on a debian/redhat based distro. Could you verify that both are actually packing the proxy stuff as intended, [~vines]? (I think you worked on that stuff most recently? If not, then whomever)
                
> Lift gen-{cpp,java,py,rb} from proxy's build.dir
> ------------------------------------------------
>
>                 Key: ACCUMULO-1008
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1008
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: proxy
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 1.5.0
>
>
> When building the tarball, only the gen-py gets included from proxy/target/, I'm guessing from the <include>**/*.py</include> in proxy/dist.xml.
> We should lift the generated thrift bindings for the proxy out of proxy/target/gen-* into its own directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira