[GitHub] spark pull request: [SPARK-11267][Core]Fix the bug that NettyRpcEn...

[zsxwing <gi...@git.apache.org>]

Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9237#discussion_r42829389
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
    @@ -262,7 +262,13 @@ object SparkEnv extends Logging {
             rpcEnv.asInstanceOf[AkkaRpcEnv].actorSystem
           } else {
             // Create a ActorSystem for legacy codes
    -        AkkaUtils.createActorSystem(actorSystemName, hostname, port, conf, securityManager)._1
    +        AkkaUtils.createActorSystem(
    +          actorSystemName + "ActorSystem",
    +          hostname,
    +          rpcEnv.address.port + 1, // Use a new port to avoid port conflicts
    --- End diff --
    
    This is not necessary for fixing this issue. Just to avoid trying to bind on a used port. I tested locally without this change and it still worked.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org