[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #10083: report minion task queue metrics at table level

[GitBox <gi...@apache.org>]

zhtaoxiang commented on code in PR #10083:
URL: https://github.com/apache/pinot/pull/10083#discussion_r1065452471


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java:
##########
@@ -364,7 +366,46 @@ public synchronized TaskCount getTaskCount(String parentTaskName) {
   }
 
   /**
-   * Returns a set of Task names (in the form "Task_TestTask_1624403781879") that are in progress or not started yet.
+   * This method returns a map of table name to count of sub-tasks in various states, given the top-level task name.
+   * @param parentTaskName in the form "Task_<taskType>_<uuid>_<timestamp>"

Review Comment:
   right, it's just a documentation improvement.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org