You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jakarta.apache.org by bu...@apache.org on 2011/01/29 15:39:40 UTC

DO NOT REPLY [Bug 50686] New: HeaderManager logging to verbose when merging instances

https://issues.apache.org/bugzilla/show_bug.cgi?id=50686

           Summary: HeaderManager logging to verbose when merging
                    instances
           Product: JMeter
           Version: Nightly (Please specify date)
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: PatchAvailable
          Severity: normal
          Priority: P2
         Component: HTTP
        AssignedTo: notifications@jakarta.apache.org
        ReportedBy: rainer.jung@kippdata.de


Created an attachment (id=26575)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26575)
Fold unneeded warn logging into debug logging

When using the feature to merge HeaderManagers, e.g. using a general instance
and then sample specific ones, there's a warn log statement issued for each
sample. This fills the log quickly, makes it hard to find serious messages in
the log file and doesn't actually add usueful information.

The attached patch merges the problematic warn logging into the existing debug
logging. The fact that merging is being done doesn't seem to warrant a warn
message, since it is a supported feature documented by the component reference
page.

Thanks for the good work on JMeter!

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org

DO NOT REPLY [Bug 50686] HeaderManager logging to verbose when merging instances

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50686

Rainer Jung <ra...@kippdata.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #2 from Rainer Jung <ra...@kippdata.de> 2011-01-30 06:04:33 EST ---
Hi Milamber,

thanks for downgrading the message.

Please reconsider merging the two debug log statements:

- The missing isDebugEnabled() for the first call makes it more expensive than
necessary. The whole argument formatting will be done before calling debug()
for every sample, even if debug logging is not activated.

- The two debug messages are redundant and joining them into one message
reduces debug log volume without removing any information from the log

Thanks again!

Rainer

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org

DO NOT REPLY [Bug 50686] HeaderManager logging to verbose when merging instances

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50686

Milamber <mi...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Milamber <mi...@apache.org> 2011-01-30 04:53:07 EST ---
Thanks. I think downgrade the log level is just sufficient.

URL: http://svn.apache.org/viewvc?rev=1065240&view=rev
Log:
Bug 50686 - HeaderManager logging to verbose when merging instances
Downgrade to debug

Modified:
   
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
    jakarta/jmeter/trunk/xdocs/changes.xml

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org

DO NOT REPLY [Bug 50686] HeaderManager logging to verbose when merging instances

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50686

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Sebb <se...@apache.org> 2011-01-30 09:57:33 EST ---
Fixed:

URL: http://svn.apache.org/viewvc?rev=1065299&view=rev
Log:
Bug 50686 - merge separate debug statements

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org