You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "David Capwell (Jira)" <ji...@apache.org> on 2020/09/29 19:38:00 UTC

[jira] [Comment Edited] (CASSANDRA-15991) 15583 - Add UX tests to intree LHF tooling

    [ https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17204237#comment-17204237 ] 

David Capwell edited comment on CASSANDRA-15991 at 9/29/20, 7:37 PM:
---------------------------------------------------------------------

Looks like a new test is failing in Circle CI - https://app.circleci.com/pipelines/github/dcapwell/cassandra/572/workflows/5bbb328d-9497-4291-8a48-ca9e04019908/jobs/3141

testFilesArg - org.apache.cassandra.tools.SSTableRepairedAtSetterTest
{code}
[org.apache.cassandra.tools.SSTableRepairedAtSetter,
    --really-set,
    --is-repaired,
    -f,
    /tmp/cassandra/sstablelist.txt]
exited with code -1
stderr:

java.lang.RuntimeException: java.nio.file.NoSuchFileException: /tmp/cassandra/sstablelist.txt
	at org.apache.cassandra.tools.ToolRunner.runClassAsTool(ToolRunner.java:99)
	at org.apache.cassandra.tools.ToolRunner.invokeClass(ToolRunner.java:256)
	at org.apache.cassandra.tools.ToolRunner.invokeClass(ToolRunner.java:232)
	at org.apache.cassandra.tools.SSTableRepairedAtSetterTest.testFilesArg(SSTableRepairedAtSetterTest.java:117)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:38)
	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:534)
	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1196)
	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:1041)
Caused by: java.nio.file.NoSuchFileException: /tmp/cassandra/sstablelist.txt
	at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
	at sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:214)
	at java.nio.file.Files.newByteChannel(Files.java:361)
	at java.nio.file.Files.newByteChannel(Files.java:407)
	at java.nio.file.spi.FileSystemProvider.newInputStream(FileSystemProvider.java:384)
	at java.nio.file.Files.newInputStream(Files.java:152)
	at java.nio.file.Files.newBufferedReader(Files.java:2784)
	at java.nio.file.Files.readAllLines(Files.java:3202)
	at org.apache.cassandra.tools.SSTableRepairedAtSetter.main(SSTableRepairedAtSetter.java:72)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.apache.cassandra.tools.ToolRunner.runClassAsTool(ToolRunner.java:79)
	... 25 more

stdout:

junit.framework.AssertionFailedError: [org.apache.cassandra.tools.SSTableRepairedAtSetter,
    --really-set,
    --is-repaired,
    -f,
    /tmp/cassandra/sstablelist.txt]
exited with code -1
stderr:

java.lang.RuntimeException: java.nio.file.NoSuchFileException: /tmp/cassandra/sstablelist.txt
	at org.apache.cassandra.tools.ToolRunner.runClassAsTool(ToolRunner.java:99)
	at org.apache.cassandra.tools.ToolRunner.invokeClass(ToolRunner.java:256)
	at org.apache.cassandra.tools.ToolRunner.invokeClass(ToolRunner.java:232)
	at org.apache.cassandra.tools.SSTableRepairedAtSetterTest.testFilesArg(SSTableRepairedAtSetterTest.java:117)
Caused by: java.nio.file.NoSuchFileException: /tmp/cassandra/sstablelist.txt
	at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
	at sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:214)
	at java.nio.file.Files.newByteChannel(Files.java:361)
	at java.nio.file.Files.newByteChannel(Files.java:407)
	at java.nio.file.spi.FileSystemProvider.newInputStream(FileSystemProvider.java:384)
	at java.nio.file.Files.newInputStream(Files.java:152)
	at java.nio.file.Files.newBufferedReader(Files.java:2784)
	at java.nio.file.Files.readAllLines(Files.java:3202)
	at org.apache.cassandra.tools.SSTableRepairedAtSetter.main(SSTableRepairedAtSetter.java:72)
	at org.apache.cassandra.tools.ToolRunner.runClassAsTool(ToolRunner.java:79)

stdout:

	at org.apache.cassandra.tools.ToolRunner$ToolResult.assertExitCode(ToolRunner.java:341)
	at org.apache.cassandra.tools.ToolRunner$ToolResult.assertOnExitCode(ToolRunner.java:335)
	at org.apache.cassandra.tools.ToolRunner$ToolResult.assertOnCleanExit(ToolRunner.java:383)
	at org.apache.cassandra.tools.SSTableRepairedAtSetterTest.testFilesArg(SSTableRepairedAtSetterTest.java:118)
{code}


was (Author: dcapwell):
Looks like a new test is failing in Circle CI

testFilesArg - org.apache.cassandra.tools.SSTableRepairedAtSetterTest
{code}
[org.apache.cassandra.tools.SSTableRepairedAtSetter,
    --really-set,
    --is-repaired,
    -f,
    /tmp/cassandra/sstablelist.txt]
exited with code -1
stderr:

java.lang.RuntimeException: java.nio.file.NoSuchFileException: /tmp/cassandra/sstablelist.txt
	at org.apache.cassandra.tools.ToolRunner.runClassAsTool(ToolRunner.java:99)
	at org.apache.cassandra.tools.ToolRunner.invokeClass(ToolRunner.java:256)
	at org.apache.cassandra.tools.ToolRunner.invokeClass(ToolRunner.java:232)
	at org.apache.cassandra.tools.SSTableRepairedAtSetterTest.testFilesArg(SSTableRepairedAtSetterTest.java:117)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:38)
	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:534)
	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1196)
	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:1041)
Caused by: java.nio.file.NoSuchFileException: /tmp/cassandra/sstablelist.txt
	at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
	at sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:214)
	at java.nio.file.Files.newByteChannel(Files.java:361)
	at java.nio.file.Files.newByteChannel(Files.java:407)
	at java.nio.file.spi.FileSystemProvider.newInputStream(FileSystemProvider.java:384)
	at java.nio.file.Files.newInputStream(Files.java:152)
	at java.nio.file.Files.newBufferedReader(Files.java:2784)
	at java.nio.file.Files.readAllLines(Files.java:3202)
	at org.apache.cassandra.tools.SSTableRepairedAtSetter.main(SSTableRepairedAtSetter.java:72)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.apache.cassandra.tools.ToolRunner.runClassAsTool(ToolRunner.java:79)
	... 25 more

stdout:

junit.framework.AssertionFailedError: [org.apache.cassandra.tools.SSTableRepairedAtSetter,
    --really-set,
    --is-repaired,
    -f,
    /tmp/cassandra/sstablelist.txt]
exited with code -1
stderr:

java.lang.RuntimeException: java.nio.file.NoSuchFileException: /tmp/cassandra/sstablelist.txt
	at org.apache.cassandra.tools.ToolRunner.runClassAsTool(ToolRunner.java:99)
	at org.apache.cassandra.tools.ToolRunner.invokeClass(ToolRunner.java:256)
	at org.apache.cassandra.tools.ToolRunner.invokeClass(ToolRunner.java:232)
	at org.apache.cassandra.tools.SSTableRepairedAtSetterTest.testFilesArg(SSTableRepairedAtSetterTest.java:117)
Caused by: java.nio.file.NoSuchFileException: /tmp/cassandra/sstablelist.txt
	at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
	at sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:214)
	at java.nio.file.Files.newByteChannel(Files.java:361)
	at java.nio.file.Files.newByteChannel(Files.java:407)
	at java.nio.file.spi.FileSystemProvider.newInputStream(FileSystemProvider.java:384)
	at java.nio.file.Files.newInputStream(Files.java:152)
	at java.nio.file.Files.newBufferedReader(Files.java:2784)
	at java.nio.file.Files.readAllLines(Files.java:3202)
	at org.apache.cassandra.tools.SSTableRepairedAtSetter.main(SSTableRepairedAtSetter.java:72)
	at org.apache.cassandra.tools.ToolRunner.runClassAsTool(ToolRunner.java:79)

stdout:

	at org.apache.cassandra.tools.ToolRunner$ToolResult.assertExitCode(ToolRunner.java:341)
	at org.apache.cassandra.tools.ToolRunner$ToolResult.assertOnExitCode(ToolRunner.java:335)
	at org.apache.cassandra.tools.ToolRunner$ToolResult.assertOnCleanExit(ToolRunner.java:383)
	at org.apache.cassandra.tools.SSTableRepairedAtSetterTest.testFilesArg(SSTableRepairedAtSetterTest.java:118)
{code}

> 15583 - Add UX tests to intree LHF tooling
> ------------------------------------------
>
>                 Key: CASSANDRA-15991
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15991
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Test/unit
>            Reporter: Berenguer Blasi
>            Assignee: Berenguer Blasi
>            Priority: Normal
>             Fix For: 4.0-beta
>
>
> As per CASSANDRA-15583 many in tree tools lack proper UX tooling: mandatory params are indeed mandatory, 'help' produces an actual help, return codes etc
> This ticket is an attempt to add it to those tools that classify as LHF. Other tools such as nodetool, with many sub-commands, deserve a separate ticket of their own



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org