svn commit: r1710390 - /lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/update/StreamingSolrClients.java

[yo...@apache.org]

Author: yonik
Date: Sat Oct 24 21:32:04 2015
New Revision: 1710390

URL: http://svn.apache.org/viewvc?rev=1710390&view=rev
Log:
doc: add comments about 1 thread for streaming update client

Modified:
    lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/update/StreamingSolrClients.java

Modified: lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/update/StreamingSolrClients.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/update/StreamingSolrClients.java?rev=1710390&r1=1710389&r2=1710390&view=diff
==============================================================================
--- lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/update/StreamingSolrClients.java (original)
+++ lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/update/StreamingSolrClients.java Sat Oct 24 21:32:04 2015
@@ -67,6 +67,9 @@ public class StreamingSolrClients {
     String url = getFullUrl(req.node.getUrl());
     ConcurrentUpdateSolrClient client = solrClients.get(url);
     if (client == null) {
+      // NOTE: increasing to more than 1 threadCount for the client could cause updates to be reordered
+      // on a greater scale since the current behavior is to only increase the number of connections/Runners when
+      // the queue is more than half full.
       client = new ConcurrentUpdateSolrClient(url, httpClient, 100, 1, updateExecutor, true) {
         @Override
         public void handleError(Throwable ex) {