[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4862: [TE] Generify centralized cache DAO and add certificate-based authentication support for Couchbase

[GitBox <gi...@apache.org>]

xiaohui-sun commented on a change in pull request #4862: [TE] Generify centralized cache DAO and add certificate-based authentication support for Couchbase
URL: https://github.com/apache/incubator-pinot/pull/4862#discussion_r352803249
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/util/CacheUtils.java
 ##########
 @@ -86,4 +93,30 @@ public static String buildQuery(JsonObject parameters) {
         parameters.getLong("start"),
         parameters.getLong("end"));
   }
+
+  /**
+   * Convert list of strings to their proper URL hosts. For each
+   * string, it will parse out the proper host for the URI.
+   * Example: "http://localhost:8091" -> "localhost"
+   * @param bootstrapUris
+   * @return
 
 Review comment:
   What is return value?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org