You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2015/11/02 17:46:52 UTC
[GitHub] tajo pull request: TAJO-1955: Add a feature to strip quotes from C...
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/840
TAJO-1955: Add a feature to strip quotes from CSV file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-1955
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/840.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #840
----
commit 278896819f1c606ba8d0caa303baa47d1afe9e5b
Author: Hyunsik Choi <hy...@apache.org>
Date: 2015-11-02T16:45:00Z
TAJO-1955: Add a feature to strip quotes from CSV file.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1955: Add a feature to strip quotes from C...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/840
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1955: Add a feature to strip quotes from C...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/840#issuecomment-153227869
Thanks for your comment. There was some my misunderstanding for this issue. It was, I understood that you try to allow delimiters between quote characters like this.
```
..., "ex, am, pl,e", ...
```
So, I concerned with that it will cost to figure out the start and end of quote characters. Sorry for my misunderstanding.
I've seen every code. After running a test manually, I'll give +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1955: Add a feature to strip quotes from C...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/840#issuecomment-153231115
You are so fast. Here is my +1.
This patch passed 'mvn install'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1955: Add a feature to strip quotes from C...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/840#issuecomment-153211891
I'm concerned with the performance decrease. Do you have any idea of this?
If not, would you mind performing some brief evaluation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1955: Add a feature to strip quotes from C...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/840#issuecomment-153215704
Could you share your thinking about the performance degradation point?
If you are concerned with the added if-condition branch, it does not matter in my opinion. Basically, it is very trivial than other code parts. In addition, ``hasQuoteChar`` is a final field, so JIT compiler will easily eliminate the added code if ``hasQuoteChar`` is false.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---