You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Brock Noland <br...@cloudera.com> on 2012/12/14 22:25:49 UTC
Review Request: FLUME-1784: JMSource fix minor documentation problem and
parameter name
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8607/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Fixes minor documentation problem and renames the converter parameter to be consistent with other components.
This addresses bug FLUME-1784.
https://issues.apache.org/jira/browse/FLUME-1784
Diffs
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst 6490710
flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSource.java e18b879
flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSourceConfiguration.java 8a311c3
flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestJMSSource.java 617393c
Diff: https://reviews.apache.org/r/8607/diff/
Testing
-------
Unit tests pass.
Thanks,
Brock Noland
Re: Review Request: FLUME-1784: JMSource fix minor documentation problem and
parameter name
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8607/
-----------------------------------------------------------
(Updated Dec. 18, 2012, 7:07 p.m.)
Review request for Flume.
Changes
-------
Latest patch
Description
-------
Fixes minor documentation problem and renames the converter parameter to be consistent with other components.
This addresses bug FLUME-1784.
https://issues.apache.org/jira/browse/FLUME-1784
Diffs (updated)
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst 6490710
flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSource.java e18b879
flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSourceConfiguration.java 8a311c3
flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestJMSSource.java 617393c
Diff: https://reviews.apache.org/r/8607/diff/
Testing
-------
Unit tests pass.
Thanks,
Brock Noland
Re: Review Request: FLUME-1784: JMSource fix minor documentation problem and
parameter name
Posted by Brock Noland <br...@cloudera.com>.
> On Dec. 18, 2012, 6:46 p.m., Hari Shreedharan wrote:
> > flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSourceConfiguration.java, line 56
> > <https://reviews.apache.org/r/8607/diff/2/?file=238868#file238868line56>
> >
> > I think I missed this last time - shouldn't this be called converter.charset?
Good catch, will fix
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8607/#review14664
-----------------------------------------------------------
On Dec. 14, 2012, 9:25 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8607/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2012, 9:25 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Fixes minor documentation problem and renames the converter parameter to be consistent with other components.
>
>
> This addresses bug FLUME-1784.
> https://issues.apache.org/jira/browse/FLUME-1784
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst 6490710
> flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSource.java e18b879
> flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSourceConfiguration.java 8a311c3
> flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestJMSSource.java 617393c
>
> Diff: https://reviews.apache.org/r/8607/diff/
>
>
> Testing
> -------
>
> Unit tests pass.
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request: FLUME-1784: JMSource fix minor documentation problem and
parameter name
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8607/#review14664
-----------------------------------------------------------
Ship it!
Looks good, just one comment. Please fix it and attach patch to jira.
flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSourceConfiguration.java
<https://reviews.apache.org/r/8607/#comment31111>
I think I missed this last time - shouldn't this be called converter.charset?
- Hari Shreedharan
On Dec. 14, 2012, 9:25 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8607/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2012, 9:25 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Fixes minor documentation problem and renames the converter parameter to be consistent with other components.
>
>
> This addresses bug FLUME-1784.
> https://issues.apache.org/jira/browse/FLUME-1784
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst 6490710
> flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSource.java e18b879
> flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSourceConfiguration.java 8a311c3
> flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestJMSSource.java 617393c
>
> Diff: https://reviews.apache.org/r/8607/diff/
>
>
> Testing
> -------
>
> Unit tests pass.
>
>
> Thanks,
>
> Brock Noland
>
>