You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "menghaoranss (via GitHub)" <gi...@apache.org> on 2026/08/28 02:55:16 UTC
[PR] Use database default schema in single rule [shardingsphere]
menghaoranss opened a new pull request, #39619:
URL: https://github.com/apache/shardingsphere/pull/39619
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
- [ ] I have disclosed the tool and affected files or scope for any material AI assistance, as required by the [AI-assisted contribution policy].
[AI-assisted contribution policy]: https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use database default schema in single rule [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss merged PR #39619:
URL: https://github.com/apache/shardingsphere/pull/39619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use database default schema in single rule [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss commented on PR #39619:
URL: https://github.com/apache/shardingsphere/pull/39619#issuecomment-5451242307
```markdown
### Result
**Review Result: Mergeable**
The change correctly aligns unqualified index resolution with the database’s effective default schema, with focused regression coverage and no confirmed correctness issues.
### Evidence
- `SingleRule.java:230` now delegates index lookup to the database-aware overload while preserving explicitly qualified index owners.
- `SingleRuleTest.java:386` distinguishes the database name from its default schema and verifies the resolved table uses `foo_default_schema`.
- Focused verification passed: `SingleRuleTest` — 35 tests, 0 failures, 0 errors; reactor build successful.
### Coverage
- Reviewed head: `1a038ecaf86a681107388b1af5b24feb3e44894a`
- Base: `468961af7d7912b3904969ae55bd30d3d94d7585`
- Accounted for all 2 authoritative changed files.
- Reviewed behavior cluster: default-schema resolution for index-based single-table routing.
- Completed root-cause, blast-radius, tests/runtime, and convergence passes.
- Unresolved gaps: none.
- Code-correctness review only; CI was not reviewed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org