[GitHub] kk580kk closed pull request #6387: Fix dockerfile nodejs version to 8.12.0

[GitBox <gi...@apache.org>]

kk580kk closed pull request #6387: Fix dockerfile nodejs version to 8.12.0
URL: https://github.com/apache/incubator-superset/pull/6387
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/contrib/docker/Dockerfile b/contrib/docker/Dockerfile
index 0debe1eddc..d79aaee343 100644
--- a/contrib/docker/Dockerfile
+++ b/contrib/docker/Dockerfile
@@ -1,4 +1,4 @@
-FROM python:3.6
+FROM kk580kk/nodejs-with-python:8.2-3.6
 
 MAINTAINER Xiao Hanyu <ha...@shopeemobile.com>
 
@@ -20,16 +20,6 @@ RUN apt-get update -y && apt-get install -y build-essential libssl-dev \
 
 RUN apt-get install -y vim less postgresql-client redis-tools
 
-# Install nodejs for custom build
-# https://github.com/apache/incubator-superset/blob/master/docs/installation.rst#making-your-own-build
-# https://nodejs.org/en/download/package-manager/
-RUN curl -sL https://deb.nodesource.com/setup_8.x | bash -
-RUN apt-get install -y nodejs
-RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -; \
-    echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list; \
-    apt-get update; \
-    apt-get install -y yarn
-
 RUN mkdir $HOME/incubator-superset
 
 WORKDIR $HOME/incubator-superset


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org