You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/09 02:40:19 UTC

[GitHub] [arrow] kou opened a new pull request #8872: ARROW-10858: [C++] Add missing Boost dependency with Visual C++

kou opened a new pull request #8872:
URL: https://github.com/apache/arrow/pull/8872


   `cpp/src/arrow/util/int128_internal.h` requires Boost.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on pull request #8872: ARROW-10858: [C++] Add missing Boost dependency with Visual C++

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8872:
URL: https://github.com/apache/arrow/pull/8872#issuecomment-743012139


   Thanks for your review.
   I'll merge this. If there is any problem in CMake related change, I'll fix it as a follow-up task.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] emkornfield commented on pull request #8872: ARROW-10858: [C++] Add missing Boost dependency with Visual C++

Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #8872:
URL: https://github.com/apache/arrow/pull/8872#issuecomment-743007540


   the 128_t changes look OK to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8872: ARROW-10858: [C++] Add missing Boost dependency with Visual C++

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8872:
URL: https://github.com/apache/arrow/pull/8872#issuecomment-741491345


   https://issues.apache.org/jira/browse/ARROW-10858


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] emkornfield commented on pull request #8872: ARROW-10858: [C++] Add missing Boost dependency with Visual C++

Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #8872:
URL: https://github.com/apache/arrow/pull/8872#issuecomment-743007636


   I'm not the best person to review the CMake changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou closed pull request #8872: ARROW-10858: [C++] Add missing Boost dependency with Visual C++

Posted by GitBox <gi...@apache.org>.
kou closed pull request #8872:
URL: https://github.com/apache/arrow/pull/8872


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org