[GitHub] [hudi] pratyakshsharma commented on a change in pull request #5071: [HUDI-1881]: draft implementation for trigger based on data availability

[GitBox <gi...@apache.org>]

pratyakshsharma commented on a change in pull request #5071:
URL: https://github.com/apache/hudi/pull/5071#discussion_r830468002



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -404,6 +396,52 @@ public void refreshTimeline() throws IOException {
     return sourceDataToSync;
   }
 
+  public boolean isDataAvailableForIngestion() throws IOException {

Review comment:
       Alternate approach for doing this can be exposing another abstract method `isDataAvailable()` in `Source` class with each source implementing its own logic. 
   
   The current way seems the easier way of doing this without much code changes. Please let me know if you approve of this @nsivabalan @vinothchandar ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org