You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/12/13 00:33:18 UTC

[GitHub] [shardingsphere] RaigorJiang edited a comment on pull request #14049: Add syntax for `DROP SHARDING KEY GENERATOR`

RaigorJiang edited a comment on pull request #14049:
URL: https://github.com/apache/shardingsphere/pull/14049#issuecomment-992005910


   Hi @Liangda-w 
   Thanks for your PR, but there are some problems that need improvement:
   
   1. This feature belongs to feature sharding, please put the syntax definition in the g4 file of the [shardingsphere-sharding-distsql](https://github.com/apache/shardingsphere/tree/master/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-parser/src/main/antlr4) module
   2. Please refer to [visitDropShardingAlgorithm](https://github.com/apache/shardingsphere/blob/master/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-parser/src/main/java/org/apache/shardingsphere/sharding/distsql/parser/core/ShardingDistSQLStatementVisitor.java) method to get `DropShardingKeyGeneratorStatement`, not simply new
   3. KeyGeneratorDefinitionStatement is not applicable for DROP, please refer to [DropShardingAlgorithmStatement](https://github.com/apache/shardingsphere/blob/master/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-statement/src/main/java/org/apache/shardingsphere/sharding/distsql/parser/statement/DropShardingAlgorithmStatement.java)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org