[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

[jaredjstewart <gi...@git.apache.org>]

Github user jaredjstewart commented on a diff in the pull request:

    https://github.com/apache/geode/pull/651#discussion_r130678413
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java ---
    @@ -633,8 +631,8 @@ public DataCommandResult put(String key, String value, boolean putIfAbsent, Stri
           try {
             keyObject = getClassObject(key, keyClass);
           } catch (ClassNotFoundException e) {
    -        return DataCommandResult.createPutResult(key, null, null,
    -            "ClassNotFoundException " + keyClass, false);
    +        return DataCommandResult.createPutResult(key, null, e.getException(),
    --- End diff --
    
    I think we can pass the Exception `e` itself rather than `e.getException()`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---