You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aicam (via GitHub)" <gi...@apache.org> on 2026/07/20 17:50:18 UTC
[PR] fix(k8s): add missing AUTH_JWT_SECRET to values-development.yaml [texera]
aicam opened a new pull request, #6610:
URL: https://github.com/apache/texera/pull/6610
### What changes were proposed in this PR?
Adds the `AUTH_JWT_SECRET` environment variable to `bin/k8s/values-development.yaml`.
The default `values.yaml` sets `AUTH_JWT_SECRET` inside `texeraEnvVars`, but `values-development.yaml` overrides `texeraEnvVars` as a **whole list**. Helm replaces lists rather than merging them, so a local install with `-f values-development.yaml` silently drops `AUTH_JWT_SECRET` from every Texera service.
The computing-unit manager reads this variable directly via `env.get(KEY).get` when launching a Kubernetes computing unit (`ComputingUnitManagingResource.scala`), so the missing value makes **computing-unit creation fail hard**:
```
java.util.NoSuchElementException: None.get
POST /api/computing-unit/create HTTP/1.1" 500
```
Any local Kubernetes deployment following the development values hits this the moment a user tries to create a computing unit. The fix adds the variable with the **same development-only default** already used in `values.yaml`, so all services share one consistent JWT signing secret.
### Any related issues, documentation, discussions?
None — standalone bug fix in the development values overlay. Independent of any other in-flight `bin/k8s` work.
### How was this PR tested?
Reproduced and verified on a local minikube cluster (`helm install ... -f values-development.yaml`):
- **Before:** creating a Kubernetes computing unit returned HTTP 500; the computing-unit manager logged `java.util.NoSuchElementException: None.get`. `kubectl exec` into the manager pod confirmed `AUTH_JWT_SECRET` was unset.
- **After** (`helm upgrade` with this change): `AUTH_JWT_SECRET` is present on the manager (and all services), the manager rolled out cleanly, and the `None.get` error no longer occurs.
Also confirmed the added value is byte-for-byte identical to the `AUTH_JWT_SECRET` default in `values.yaml`, so development and production use the same variable and the dev overlay stops diverging.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(k8s): add missing AUTH_JWT_SECRET to values-development.yaml [texera]
Posted by "aicam (via GitHub)" <gi...@apache.org>.
aicam merged PR #6610:
URL: https://github.com/apache/texera/pull/6610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(k8s): add missing AUTH_JWT_SECRET to values-development.yaml [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #6610:
URL: https://github.com/apache/texera/pull/6610#discussion_r3616931654
##########
bin/k8s/values-development.yaml:
##########
@@ -352,6 +352,9 @@ texeraEnvVars:
value: ""
- name: USER_SYS_DOMAIN
value: ""
+ - name: AUTH_JWT_SECRET
+ # Development-only default (256-bit HS256 secret). Production environments MUST override this with a different, securely generated secret.
+ value: "a7f3c8e9b14d2e6f5a0b9c3d8e1f4a6b2c5d7e9f0a3b6c8d1e4f7a9b2c5d8e1f"
Review Comment:
Instead of hardcoding a value here, can we leave this field empty? For example, if the field is empty, it could automatically generate a random key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(k8s): add missing AUTH_JWT_SECRET to values-development.yaml [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6610:
URL: https://github.com/apache/texera/pull/6610#issuecomment-5025384969
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@bobbai00`
You can notify them by mentioning `@bobbai00` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(k8s): add missing AUTH_JWT_SECRET to values-development.yaml [texera]
Posted by "aicam (via GitHub)" <gi...@apache.org>.
aicam commented on code in PR #6610:
URL: https://github.com/apache/texera/pull/6610#discussion_r3617572004
##########
bin/k8s/values-development.yaml:
##########
@@ -352,6 +352,9 @@ texeraEnvVars:
value: ""
- name: USER_SYS_DOMAIN
value: ""
+ - name: AUTH_JWT_SECRET
+ # Development-only default (256-bit HS256 secret). Production environments MUST override this with a different, securely generated secret.
+ value: "a7f3c8e9b14d2e6f5a0b9c3d8e1f4a6b2c5d7e9f0a3b6c8d1e4f7a9b2c5d8e1f"
Review Comment:
I checked and we can't do it for two reasons:
- HMAC needs exactly 64 characters so empty is not accepted
- Generating random string requires updates on Kubernetes and using the key in security refs which is overkill for this
To make sure this token does not cause issue, I changed it to be 64 characters all "a". Tokens have specific patterns so it will not be considered as a token.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(k8s): add missing AUTH_JWT_SECRET to values-development.yaml [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #6610:
URL: https://github.com/apache/texera/pull/6610#discussion_r3616931654
##########
bin/k8s/values-development.yaml:
##########
@@ -352,6 +352,9 @@ texeraEnvVars:
value: ""
- name: USER_SYS_DOMAIN
value: ""
+ - name: AUTH_JWT_SECRET
+ # Development-only default (256-bit HS256 secret). Production environments MUST override this with a different, securely generated secret.
+ value: "a7f3c8e9b14d2e6f5a0b9c3d8e1f4a6b2c5d7e9f0a3b6c8d1e4f7a9b2c5d8e1f"
Review Comment:
Instead of hardcoding a value here, can we leave this field empty? For example, if the field is empty, it could automatically generate a random key.
I’m a little concerned that having a hardcoded value here could trigger security scanners, similar to what happened with the Twitter key today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org