You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2015/08/10 07:03:45 UTC

[jira] [Commented] (LUCENE-6716) Improve SpanPayloadCheckQuery API

    [ https://issues.apache.org/jira/browse/LUCENE-6716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679566#comment-14679566 ] 

David Smiley commented on LUCENE-6716:
--------------------------------------

+1 LGTM.  I assumed you renamed the test in the patch; I didn't look at that part line by line.

Separately, IMO PayloadSpanCollector should be marked as {{@lucene.experimental}} as it still has the sad Collection<byte[]> API.

> Improve SpanPayloadCheckQuery API
> ---------------------------------
>
>                 Key: LUCENE-6716
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6716
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>         Attachments: LUCENE-6716.patch
>
>
> SpanPayloadCheckQuery currently takes a Collection<byte[]> to check its payloads against.  This is suboptimal a) because payloads internally use BytesRef rather than byte[] and b) Collection is unordered, but the implementation does actually care about the order in which the payloads appear.
> We should change the constructor to take a List<BytesRef> instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org