[GitHub] [airflow] jedcunningham commented on a diff in pull request #25056: Disable provider packages building for non-main branch builds

[GitBox <gi...@apache.org>]

jedcunningham commented on code in PR #25056:
URL: https://github.com/apache/airflow/pull/25056#discussion_r924048917


##########
Dockerfile:
##########
@@ -1283,16 +1283,23 @@ ENV AIRFLOW_PIP_VERSION=${AIRFLOW_PIP_VERSION} \
 COPY --from=scripts common.sh install_pip_version.sh \
      install_airflow_dependencies_from_branch_tip.sh /scripts/docker/
 
+# We can set this value to true in case we want to install .whl .tar.gz packages placed in the
+# docker-context-files folder. This can be done for both - additional packages you want to install
+# as well as Airflow and Provider packages (it will be automatically detected if airflow
+# is installed from docker-context files rather than from PyPI

Review Comment:
   ```suggestion
   # We can set this value to true in case we want to install .whl/.tar.gz packages placed in the
   # docker-context-files folder. This can be done for both additional packages you want to install
   # as well as Airflow and Provider packages (it will be automatically detected if airflow
   # is installed from docker-context files rather than from PyPI)
   ```
   
   nit



##########
.github/workflows/build-images.yml:
##########
@@ -319,12 +319,10 @@ ${{ hashFiles('.pre-commit-config.yaml') }}"
           key: "pre-commit-${{steps.host-python-version.outputs.host-python-version}}-\
 ${{ hashFiles('.pre-commit-config.yaml') }}"
           restore-keys: pre-commit-${{steps.host-python-version.outputs.host-python-version}}
-        if: needs.build-info.outputs.default-branch == 'main'

Review Comment:
   Do we need to be more specific, main or stable branches? Not sure we need/want to do this for committers pushing branches to apache/airflow?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org