You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/13 14:23:49 UTC
[GitHub] [rocketmq] ferrirW opened a new pull request #3641: [ISSUE #3640] Try throw exception when some broke create topic failed
ferrirW opened a new pull request #3641:
URL: https://github.com/apache/rocketmq/pull/3641
**Make sure set the target branch to `develop`**
## What is the purpose of the change
- Let user know details when some brokers create topic failed
## Brief changelog
- consider all broker create topic as success
- throw exception with success an failed broker information
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3641: [ISSUE #3640] Try throw exception when some broke create topic failed
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3641:
URL: https://github.com/apache/rocketmq/pull/3641#issuecomment-992612060
[](https://coveralls.io/builds/44958038)
Coverage decreased (-0.04%) to 56.194% when pulling **6dbce679fa44ece3116db86bd87263fd49538bfd on ferrirW:polish-create-topic** into **4a8263b4609cd16b5e7c194528bd875711e01852 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ni-ze commented on pull request #3641: [ISSUE #3640] Try throw exception when some broke create topic failed
Posted by GitBox <gi...@apache.org>.
ni-ze commented on pull request #3641:
URL: https://github.com/apache/rocketmq/pull/3641#issuecomment-1002842001
the title is imprecise, It is recommended to modify it to
```
Find out which broker failed, when use MQAdminImpl#createTopic method.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org