[GitHub] [arrow] rok commented on pull request #12154: ARROW-14821: [R] Implement bindings for lubridate's floor_date, ceiling_date, and round_date

[GitBox <gi...@apache.org>]

rok commented on pull request #12154:
URL: https://github.com/apache/arrow/pull/12154#issuecomment-1063657721


   No worries @djnavarro :)
   About `week_start` - are you sure we need anything but 1 and 7 (which maps to `week_starts_monday=true/false` respectively)? It's relatively straight forward to implement in c++ (and we should probably do it there) but does anyone ever need that? I'm honestly curious. Maybe someone does need it?
   
   About the `change_on_boundary` - would that be useful for rollup too? See [my comment here](https://issues.apache.org/jira/browse/ARROW-11090?focusedCommentId=17503922&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17503922). [Add/subtract kernels can now handle temporal types](https://arrow.apache.org/docs/dev/cpp/compute.html#arithmetic-functions) so you could use them to subtract a single time unit of duration from a timestamp if that's what you'd need.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org