[GitHub] [superset] villebro commented on a diff in pull request #25469: fix(sqllab): error with lazy_gettext for tab titles

["villebro (via GitHub)" <gi...@apache.org>]

villebro commented on code in PR #25469:
URL: https://github.com/apache/superset/pull/25469#discussion_r1341808950


##########
superset/views/sql_lab/views.py:
##########
@@ -90,7 +90,7 @@ def post(self) -> FlaskResponse:
             user_id=get_user_id(),
             # This is for backward compatibility
             label=query_editor.get("name")
-            or query_editor.get("title", _("Untitled Query")),
+            or query_editor.get("title", str(_("Untitled Query"))),

Review Comment:
   To simplify could we just `gettext`? I don't think this needs to be lazy.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org