You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Shwetha GS <ss...@hortonworks.com> on 2016/06/08 11:41:23 UTC
Review Request 48408: ATLAS-749 Make EntityAuditRepository
implementation configurable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48408/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-749
https://issues.apache.org/jira/browse/ATLAS-749
Repository: atlas
Description
-------
1. Makes audit repository implementation configurable
2. Made in memory audit repo as default for berkley, es profile
3. Updated docs
Diffs
-----
distro/pom.xml 131a488
distro/src/conf/atlas-application.properties 1cdd424
docs/src/site/twiki/Configuration.twiki 7150483
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 15201dd
typesystem/src/main/resources/atlas-application.properties 3318ff3
webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 010fa2a
webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 08bb125
webapp/src/test/java/org/apache/atlas/web/listeners/TestModule.java 9cb76d3
Diff: https://reviews.apache.org/r/48408/diff/
Testing
-------
Existing tests passed, tested end to end
Thanks,
Shwetha GS
Re: Review Request 48408: ATLAS-749 Make EntityAuditRepository
implementation configurable
Posted by Jeff Hagelberg <jn...@us.ibm.com>.
> On June 8, 2016, 2:08 p.m., Jeff Hagelberg wrote:
> > One minor comment - there is really no point in accumulating the audit repository events in memory in production. I could see it potentially using a lot of memory, since it is never cleaned up. It may make sense to add a Noop implementation that can be used in production environments where hbase is unavailable.
One more comment - atlas_start.py currently fails if hbase is not selected as the repository. My changes for ATLAS-749 included logic to tolerate something other than hbase being used as the repository. I also added the delete handler property to atlas-application.properties, since it was missing. You can see the changes I made here: https://reviews.apache.org/r/48349/
- Jeff
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48408/#review136641
-----------------------------------------------------------
On June 8, 2016, 11:41 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48408/
> -----------------------------------------------------------
>
> (Updated June 8, 2016, 11:41 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-749
> https://issues.apache.org/jira/browse/ATLAS-749
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Makes audit repository implementation configurable
> 2. Made in memory audit repo as default for berkley, es profile
> 3. Updated docs
>
>
> Diffs
> -----
>
> distro/pom.xml 131a488
> distro/src/conf/atlas-application.properties 1cdd424
> docs/src/site/twiki/Configuration.twiki 7150483
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 15201dd
> typesystem/src/main/resources/atlas-application.properties 3318ff3
> webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 010fa2a
> webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 08bb125
> webapp/src/test/java/org/apache/atlas/web/listeners/TestModule.java 9cb76d3
>
> Diff: https://reviews.apache.org/r/48408/diff/
>
>
> Testing
> -------
>
> Existing tests passed, tested end to end
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 48408: ATLAS-749 Make EntityAuditRepository
implementation configurable
Posted by Shwetha GS <ss...@hortonworks.com>.
> On June 8, 2016, 2:08 p.m., Jeff Hagelberg wrote:
> > One minor comment - there is really no point in accumulating the audit repository events in memory in production. I could see it potentially using a lot of memory, since it is never cleaned up. It may make sense to add a Noop implementation that can be used in production environments where hbase is unavailable.
>
> Jeff Hagelberg wrote:
> One more comment - atlas_start.py currently fails if hbase is not selected as the repository. My changes for ATLAS-749 included logic to tolerate something other than hbase being used as the repository. I also added the delete handler property to atlas-application.properties, since it was missing. You can see the changes I made here: https://reviews.apache.org/r/48349/
Yes, in-meory is bad, I added it as it was already there. With no-op implementation, audit functionality will not work. The default implementation should use some persistent store, without hbase, it can probably be derby. But any other implementation, lets go with no-op for now.
I will close this, lets get your patch in. Can you re-open your review and add atlas group in the review request
- Shwetha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48408/#review136641
-----------------------------------------------------------
On June 8, 2016, 11:41 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48408/
> -----------------------------------------------------------
>
> (Updated June 8, 2016, 11:41 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-749
> https://issues.apache.org/jira/browse/ATLAS-749
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Makes audit repository implementation configurable
> 2. Made in memory audit repo as default for berkley, es profile
> 3. Updated docs
>
>
> Diffs
> -----
>
> distro/pom.xml 131a488
> distro/src/conf/atlas-application.properties 1cdd424
> docs/src/site/twiki/Configuration.twiki 7150483
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 15201dd
> typesystem/src/main/resources/atlas-application.properties 3318ff3
> webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 010fa2a
> webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 08bb125
> webapp/src/test/java/org/apache/atlas/web/listeners/TestModule.java 9cb76d3
>
> Diff: https://reviews.apache.org/r/48408/diff/
>
>
> Testing
> -------
>
> Existing tests passed, tested end to end
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 48408: ATLAS-749 Make EntityAuditRepository
implementation configurable
Posted by Jeff Hagelberg <jn...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48408/#review136641
-----------------------------------------------------------
One minor comment - there is really no point in accumulating the audit repository events in memory in production. I could see it potentially using a lot of memory, since it is never cleaned up. It may make sense to add a Noop implementation that can be used in production environments where hbase is unavailable.
- Jeff Hagelberg
On June 8, 2016, 11:41 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48408/
> -----------------------------------------------------------
>
> (Updated June 8, 2016, 11:41 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-749
> https://issues.apache.org/jira/browse/ATLAS-749
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Makes audit repository implementation configurable
> 2. Made in memory audit repo as default for berkley, es profile
> 3. Updated docs
>
>
> Diffs
> -----
>
> distro/pom.xml 131a488
> distro/src/conf/atlas-application.properties 1cdd424
> docs/src/site/twiki/Configuration.twiki 7150483
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 15201dd
> typesystem/src/main/resources/atlas-application.properties 3318ff3
> webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 010fa2a
> webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 08bb125
> webapp/src/test/java/org/apache/atlas/web/listeners/TestModule.java 9cb76d3
>
> Diff: https://reviews.apache.org/r/48408/diff/
>
>
> Testing
> -------
>
> Existing tests passed, tested end to end
>
>
> Thanks,
>
> Shwetha GS
>
>